in that case what should we do if we realize that not a single mac addresses were found on the switch? should we simply ignore it (current solution) or should we clear existing configurations to a…
that's one of the options, yes 😉 the fixme is just stating the problem: we should not use directly this type from harmony_inventory_agent
possible solutions are:
- (what you suggested)…
for better readability, please add a white line between function declarations to give a bit of space
could it be interesting to move such function into the k8s_client so that others could use it easily?
Considering we try to do as little yaml as possible, maybe it would be better to introduce a Resource for this?
is it a typo? cet-manager instead of cert-manager?
It was easy to do so, so I pushed this logic inside the Brocade crate.
We might have to interact with something higher level than a "switch" for a more generic API but we're not there…
LGTM
Just a quick suggestion: for the PR title, try to describe what you are fixing (e.g. fix(argo-cd): auto assign user group for namespace) and then in your description add more details…
Is this deletion expected? Did it have any impact on the issue?
cf0b8326dc
Merge pull request 'fix: properly configured discord alert receiver corrected domain and topic name for ntfy' (#154) from fix/alertreceivers into master
