I think we should leave it to the implementers to define their Debug impl. So on line 6 we should have pub trait NodeExporter: std::fmt::Debug + Send + Sync instead.
Could you make a quick screen recording of this change in action? 📹
2d891e4463
Merge pull request 'feat(host_network): configure bonds and port channels' (#169) from config-host-network into master
2d891e4463
Merge pull request 'feat(host_network): configure bonds and port channels' (#169) from config-host-network into master
6989d208cf
Merge pull request 'feat(switch/brocade): Implement client to interact with Brocade switches' (#168) from brocade-switch-client into master
Left a few comments here and there that could be small improvements for a future PR
a quick cleanup/refactoring for this function could make things easier to read/understand, for example by breaking down the different steps into different (module private) functions
In addition to the comment above, I think it wouldn't be too tricky to refactor (if needed in another PR) with something like:
Does it have to be that specific? Or would it be ok if the signature was Result<Option<String>, Error> and that users of this function can decide what to do without values?