Ian Letourneau letian
0 Followers · 0 Following
  • Joined on 2025-04-08
Repositories Projects Packages Public Activity Starred Repositories
letian commented on pull request NationTech/harmony#167 2025-10-20 18:52:21 +00:00
feat(application): Webapp feature with production dns

still needed?

letian commented on pull request NationTech/harmony#167 2025-10-20 18:50:15 +00:00
feat(application): Webapp feature with production dns

In addition to the comment above, I think it wouldn't be too tricky to refactor (if needed in another PR) with something like:

letian commented on pull request NationTech/harmony#167 2025-10-20 18:43:12 +00:00
feat(application): Webapp feature with production dns

Does it have to be that specific? Or would it be ok if the signature was Result<Option<String>, Error> and that users of this function can decide what to do without values?

letian commented on pull request NationTech/harmony#167 2025-10-20 18:39:56 +00:00
feat(application): Webapp feature with production dns

Should it be doc comments?

letian commented on pull request NationTech/harmony#170 2025-10-20 18:35:25 +00:00
feat/impl_installable_crd_prometheus

dead code?

letian commented on pull request NationTech/harmony#170 2025-10-20 18:29:37 +00:00
feat/impl_installable_crd_prometheus

I don't think we should completely ignore the error here

letian commented on pull request NationTech/harmony#170 2025-10-20 18:28:33 +00:00
feat/impl_installable_crd_prometheus

Small detail, but we could also use service_monitors: service_monitors.unwrap_or_default() here:

letian commented on pull request NationTech/harmony#170 2025-10-20 18:18:09 +00:00
feat/impl_installable_crd_prometheus

should it be implemented?

letian commented on pull request NationTech/harmony#170 2025-10-20 18:16:12 +00:00
feat/impl_installable_crd_prometheus

This function doesn't seem to be used

letian commented on pull request NationTech/harmony#171 2025-10-20 18:12:41 +00:00
feat: scrape targets to be able to get snmp alerts from machines to prometheus

Do we have to actually configure something here? Because we pass an empty list it doesn't seem used.

letian commented on pull request NationTech/harmony#171 2025-10-20 18:10:14 +00:00
feat: scrape targets to be able to get snmp alerts from machines to prometheus

Should it be scrape_targets? as it's a vector

letian pushed to nmstate at NationTech/harmony 2025-10-17 15:39:52 +00:00
83fcf9e8ac wip
letian pushed to nmstate at NationTech/harmony 2025-10-16 21:07:36 +00:00
dbd1f1b010 install operatorhub to configure nmstate
letian created branch nmstate in NationTech/harmony 2025-10-16 21:07:36 +00:00
letian deleted branch config-host-network from NationTech/harmony 2025-10-16 18:25:07 +00:00
letian pushed to master at NationTech/harmony 2025-10-16 18:25:01 +00:00
2d891e4463 Merge pull request 'feat(host_network): configure bonds and port channels' (#169) from config-host-network into master
f66e58b9ca Merge branch 'master' into config-host-network
ea39d93aa7 feat(host_network): configure bonds on the host and switch port channels
Compare 3 commits »
letian merged pull request NationTech/harmony#169 2025-10-16 18:24:59 +00:00
feat(host_network): configure bonds and port channels
letian pushed to config-host-network at NationTech/harmony 2025-10-16 18:24:40 +00:00
f66e58b9ca Merge branch 'master' into config-host-network
6989d208cf Merge pull request 'feat(switch/brocade): Implement client to interact with Brocade switches' (#168) from brocade-switch-client into master
Compare 2 commits »
letian pushed to config-host-network at NationTech/harmony 2025-10-16 18:24:16 +00:00
ea39d93aa7 feat(host_network): configure bonds on the host and switch port channels
letian deleted branch brocade-switch-client from NationTech/harmony 2025-10-16 18:23:10 +00:00