Ian Letourneau letian
  • Joined on 2025-04-08
letian pushed to refactor-network-manager at NationTech/harmony 2025-11-05 23:50:26 +00:00
3f6c6da802 adjust merge
letian pushed to refactor-network-manager at NationTech/harmony 2025-11-05 23:48:14 +00:00
79db278060 Merge branch 'master' into refactor-network-manager
9d4e6acac0 fix(host_network): retrieve proper hostname and next available bond id (#182)
4ff57062ae Merge pull request 'feat(kube): Convert kube_openapi Resource to DynamicObject' (#180) from feat/kube_convert_dynamic_resource into master
95cfc03518 feat(kube): Utility function to convert kube_openapi Resource to DynamicObject. This will allow initializing resources strongly typed and then bundle various types into a list of DynamicObject
Compare 4 commits »
letian deleted branch network-manager from NationTech/harmony 2025-11-05 23:38:31 +00:00
letian pushed to master at NationTech/harmony 2025-11-05 23:38:27 +00:00
9d4e6acac0 fix(host_network): retrieve proper hostname and next available bond id (#182)
letian merged pull request NationTech/harmony#182 2025-11-05 23:38:25 +00:00
fix(host_network): retrieve proper hostname and next available bond id
letian pushed to network-manager at NationTech/harmony 2025-11-05 23:38:04 +00:00
db80dafa99 remove extra check for filtering existing bonds
letian pushed to network-manager at NationTech/harmony 2025-11-05 23:36:09 +00:00
ae6ab24e53 Merge branch 'master' into network-manager
4ff57062ae Merge pull request 'feat(kube): Convert kube_openapi Resource to DynamicObject' (#180) from feat/kube_convert_dynamic_resource into master
95cfc03518 feat(kube): Utility function to convert kube_openapi Resource to DynamicObject. This will allow initializing resources strongly typed and then bundle various types into a list of DynamicObject
Compare 3 commits »
letian commented on pull request NationTech/harmony#182 2025-11-05 23:32:42 +00:00
fix(host_network): retrieve proper hostname and next available bond id

good point, I'll remove the second part of the check

letian commented on pull request NationTech/harmony#183 2025-11-05 23:26:10 +00:00
refactor(host_network): extract NetworkManager as a reusable component

I wanted to use hurl! at first but it creates an enum that match either an URL or a local folder. The url would have been nice, but I'm not sure what to do if it's a local folder. So it made…

letian commented on pull request NationTech/harmony#183 2025-11-05 23:21:56 +00:00
refactor(host_network): extract NetworkManager as a reusable component

Agree with using stuff like thiserror in general, especially for the core.

The tricky is thing is that here, it is not part of the core of Harmony strictly speaking. The Switch and the…

letian commented on pull request NationTech/harmony#183 2025-11-05 23:08:26 +00:00
refactor(host_network): extract NetworkManager as a reusable component

it's actually the impl Switch for HAClusterTopology

letian commented on pull request NationTech/harmony#183 2025-11-05 23:07:38 +00:00
refactor(host_network): extract NetworkManager as a reusable component

In pure Rust, the main difference is that OnceLock is the multi-threaded version of OnceCell. Considering our initialization process is synchronous in that case, I preferred to use this…

letian created pull request NationTech/harmony#186 2025-11-05 22:47:12 +00:00
fix(host_network): remove extra fields from bond config to prevent clashes
letian pushed to fix-bond-config at NationTech/harmony 2025-11-05 22:46:14 +00:00
77dae13cba fix(host_network): remove extra fields from bond config to prevent clashes
letian created branch fix-bond-config in NationTech/harmony 2025-11-05 22:46:13 +00:00
letian pushed to fix-bond-for-one-interface at NationTech/harmony 2025-11-05 20:02:38 +00:00
1d5ef24844 revert last changes (was unnecessary)
letian pushed to fix-bond-for-one-interface at NationTech/harmony 2025-11-05 19:53:47 +00:00
c166351d8b fix nmstate attribute
letian pushed to fix-bond-for-one-interface at NationTech/harmony 2025-11-05 18:26:40 +00:00
7fe15ffa24 remove unnecessary println
letian pushed to fix-bond-for-one-interface at NationTech/harmony 2025-11-05 18:22:29 +00:00
cb7b9d4088 remove unnecessary println
letian pushed to fix-bond-for-one-interface at NationTech/harmony 2025-11-05 18:20:55 +00:00
45bf3cf265 remove unnecessary println