NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

feat/impl_installable_crd_prometheus #170

Open
wjro wants to merge 9 commits from feat/impl_installable_crd_prometheus into master
pull from: feat/impl_installable_crd_prometheus
merge into: NationTech:master
Conversation 0 Commits 9 Files Changed 17 +705 -146
wjro commented 2025-10-16 18:09:58 +00:00
Owner
Copy Link

feat: implementation of Installable for CRDPrometheusIntroduction of Grafana trait and its impl for k8sanywhere
allows for CRDPrometheus to be installed via AlertingInterpret which standardizes the installation of alert receivers, alerting rules, and alert senders

feat: implementation of Installable for CRDPrometheusIntroduction of Grafana trait and its impl for k8sanywhere allows for CRDPrometheus to be installed via AlertingInterpret which standardizes the installation of alert receivers, alerting rules, and alert senders
wjro added 7 commits 2025-10-16 18:09:59 +00:00
feat:added k8s flavour to k8s_aywhere topology to be able to get the type of cluster
All checks were successful
Run Check Script / check (pull_request) Successful in 33s
Details
f073b7e5fb
wjro added 1 commit 2025-10-16 18:17:44 +00:00
Merge remote-tracking branch 'origin/master' into feat/impl_installable_crd_prometheus
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
c0d54a4466
letian reviewed 2025-10-20 18:16:11 +00:00
harmony/src/domain/topology/k8s.rs
@ -59,6 +60,22 @@ impl K8sClient {
})
}
pub async fn service_account_api(&self, namespace: &str) -> Api<ServiceAccount> {
letian commented 2025-10-20 18:16:11 +00:00
Owner
Copy Link

This function doesn't seem to be used

This function doesn't seem to be used
letian reviewed 2025-10-20 18:18:09 +00:00
harmony/src/domain/topology/k8s_anywhere.rs
@ -149,0 +308,4 @@
sender: &RHOBObservability,
inventory: &Inventory,
) -> Result<PreparationOutcome, PreparationError> {
todo!()
letian commented 2025-10-20 18:18:09 +00:00
Owner
Copy Link

should it be implemented?

should it be implemented?
wjro commented 2025-10-20 19:16:54 +00:00
Author
Owner
Copy Link

yes it should but this is out of scope for this pr, im only working on impl installable for alert sender CRDPrometheus

yes it should but this is out of scope for this pr, im only working on impl installable for alert sender CRDPrometheus
wjro marked this conversation as resolved
letian reviewed 2025-10-20 18:28:33 +00:00
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@ -197,3 +588,1 @@
receivers: receivers.unwrap_or_default(),
service_monitors: vec![],
prometheus_rules: vec![],
if let Some(sm) = service_monitors {
letian commented 2025-10-20 18:28:33 +00:00
Owner
Copy Link

Small detail, but we could also use service_monitors: service_monitors.unwrap_or_default() here:

            return K8sPrometheusCRDAlertingScore {
                sender,
                receivers: receivers.unwrap_or_default(),
                service_monitors: service_monitors.unwrap_or_default(),
                prometheus_rules: vec![],
            };
Small detail, but we could also use `service_monitors: service_monitors.unwrap_or_default()` here: ```rs return K8sPrometheusCRDAlertingScore { sender, receivers: receivers.unwrap_or_default(), service_monitors: service_monitors.unwrap_or_default(), prometheus_rules: vec![], }; ```
wjro marked this conversation as resolved
letian reviewed 2025-10-20 18:29:37 +00:00
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@ -468,0 +880,4 @@
if tenant.is_some() {
namespace_scope = true;
}
let _grafana_operator_score = grafana_helm_chart_score(namespace, namespace_scope)
letian commented 2025-10-20 18:29:37 +00:00
Owner
Copy Link

I don't think we should completely ignore the error here

I don't think we should completely ignore the error here
wjro marked this conversation as resolved
letian reviewed 2025-10-20 18:35:25 +00:00
harmony/src/modules/prometheus/k8s_prometheus_alerting_score.rs
@ -469,2 +470,2 @@
let mut json_data = BTreeMap::new();
json_data.insert("timeInterval".to_string(), "5s".to_string());
// let mut json_data = BTreeMap::new();
// json_data.insert("timeInterval".to_string(), "5s".to_string());
letian commented 2025-10-20 18:35:25 +00:00
Owner
Copy Link

dead code?

dead code?
wjro marked this conversation as resolved
wjro added 1 commit 2025-10-20 19:31:11 +00:00
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
This pull request has changes conflicting with the target branch.
  • harmony/src/domain/topology/k8s.rs
  • harmony/src/domain/topology/k8s_anywhere.rs
  • harmony/src/domain/topology/oberservability/monitoring.rs
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/impl_installable_crd_prometheus:feat/impl_installable_crd_prometheus
git checkout feat/impl_installable_crd_prometheus
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#170
No description provided.
Delete Branch "feat/impl_installable_crd_prometheus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?