feat: scrape targets to be able to get snmp alerts from machines to prometheus #171

wjro · 2025-10-20T15:45:48Z

wjro commented

2025-10-20 15:45:48 +00:00

No description provided.

wjro added 1 commit 2025-10-20 15:45:49 +00:00

feat: scrape targets to be able to get snmp alerts from machines to prometheus

Run Check Script / check (pull_request) Has been cancelled

Details

a815f6ac9c

letian reviewed 2025-10-20 18:10:14 +00:00

harmony/src/domain/topology/oberservability/monitoring.rs Outdated

						
				@@ -21,6 +21,7 @@ pub struct AlertingInterpret<S: AlertSender> {

				    pub sender: S,

				    pub receivers: Vec<Box<dyn AlertReceiver<S>>>,

				    pub rules: Vec<Box<dyn AlertRule<S>>>,

				    pub scrape_target: Vec<Box<dyn ScrapeTarget<S>>>,

letian commented

2025-10-20 18:10:14 +00:00

Should it be scrape_targets? as it's a vector

Should it be `scrape_targets`? as it's a vector

letian marked this conversation as resolved

letian reviewed 2025-10-20 18:12:41 +00:00

harmony/src/modules/monitoring/kube_prometheus/helm_prometheus_alert_score.rs Outdated

						
				@@ -31,6 +31,7 @@ impl<T: Topology + HelmCommand + TenantManager> Score<T> for HelmPrometheusAlert

				            sender: KubePrometheus { config },

				            receivers: self.receivers.clone(),

				            rules: self.rules.clone(),

				            scrape_target: vec![],