NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

refactor(ha_cluster): inject switch client for better testability #174

Open
letian wants to merge 1 commits from switch-client into master
pull from: switch-client
merge into: NationTech:master
Conversation 0 Commits 1 Files Changed 16 +197 -77
letian commented 2025-10-22 19:15:31 +00:00
Owner
Copy Link

Quick refactor in order to inject a SwitchClient into the HAClusterTopology instead of hardcoding its implementation.
In the future, this will allow us to write automated tests targeting the topology or even higher level test suites.

Note: the public_clouds are already updated.

Quick refactor in order to inject a `SwitchClient` into the `HAClusterTopology` instead of hardcoding its implementation. In the future, this will allow us to write automated tests targeting the topology or even higher level test suites. Note: the `public_clouds` are already updated.
letian added 1 commit 2025-10-22 19:15:31 +00:00
fix(ha_cluster): inject switch client for better testability
Some checks are pending
Run Check Script / check (pull_request) Waiting to run
Details
7368184917
letian changed title from fix(ha_cluster): inject switch client for better testability to refactor(ha_cluster): inject switch client for better testability 2025-10-22 19:28:34 +00:00
Some checks are pending
Run Check Script / check (pull_request) Waiting to run
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin switch-client:switch-client
git checkout switch-client
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#174
No description provided.
Delete Branch "switch-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?