johnride
  • Joined on 2024-02-06
johnride commented on pull request NationTech/harmony#11 2025-04-23 14:52:46 +00:00
tui-score-info

delete

johnride commented on pull request NationTech/harmony#11 2025-04-23 14:52:46 +00:00
tui-score-info

Better understand the use case here, or replace the debug with "UNSUPPORTED KEY TYPE"

johnride approved NationTech/harmony#11 2025-04-23 14:52:46 +00:00
tui-score-info
johnride commented on pull request NationTech/harmony#11 2025-04-23 14:52:46 +00:00
tui-score-info

delete

johnride pushed to tui-score-info at NationTech/harmony 2025-04-23 14:38:03 +00:00
3e032b79f6 chore: Move large score to function
johnride pushed to tui-score-info at NationTech/harmony 2025-04-23 14:33:47 +00:00
27f6ed97f9 chore: Add heavy score example to tui to see what it looks like with long output. Good enough as a step forward!
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-23 14:16:26 +00:00
0ac8ba054a Switch HAClusterTopology for K8sAnywhereTopology in lamp example
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-19 19:25:49 +00:00
9995592238 feat: add k3d installation interpret
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-19 19:06:37 +00:00
fe44db6270 chore: Refactor DownloadableAsset tests to use httptest instead of a local TcpListener
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-19 03:46:16 +00:00
b1e5f0912c fix: Initialize K3DInstallationScore correctly
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-19 03:41:09 +00:00
a73880e0f6 chore: Cargo fmt
9da3c5e1ee feat: download and install k3d latest release
7fae8e417b wip: Started work on k3d crate
3569d7534e wip: Implement basic K8sAnywhere setup with K3d support
2068a597ea feat: Introduce K8sAnywhereTopology and refactor Kubernetes interactions
Compare 8 commits »
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-19 03:37:21 +00:00
60c72bb328 chore: Cargo fmt
e65e73ce89 feat: download and install k3d latest release
Compare 2 commits »
johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Either I don't understand it or it's an outdated comment, I think those types of comment explaining WHAT the code is doing are generally bad. Comments should explain WHY. If you need to express a WHAT, use a function.

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

So much better. I think there are more Rust idiomatic ways to handle that with Slices or something but it's good enough :

johnride approved NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

This is just so much better. And it shows in the UX. Usually a good UX requires good code and good code produces a good UX.

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

This function, though pretty simple, deserves a test. Could be a good place for a doctest. Not necessary though, just spilling my thoughts.

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Those 8 lines should be extracted to a utilty function in the test module such as "init_test_maestro() -> Maestro"

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Weird comment here again, does not relate directly to the code block. I think I'd rather not have it.

johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-17 17:04:09 +00:00
34b046c7cc wip: Started work on k3d crate
johnride suggested changes for NationTech/harmony#9 2025-04-17 15:24:57 +00:00
feat: harmony-cli v0.1 #8

Few things to fix still :