NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

feat: add cert-manager module and helm repo support #31

Merged
johnride merged 1 commits from feat/awsOKD into master 2025-05-06 16:39:19 +00:00
Conversation 1 Commits 1 Files Changed 7 +183 -7
johnride commented 2025-05-06 16:34:15 +00:00
Owner
Copy Link
  • Implemented a new cert-manager module for deploying cert-manager.
  • Added support for specifying a Helm repository in module configurations.
  • Introduced cert_manager module in modules/mod.rs.
  • Created src/modules/cert_manager directory and its associated code.
  • Implemented add_repo function in src/modules/helm.rs for adding Helm repositories.
  • Updated LAMPInterpret and lamp.rs to integrate the new module.
  • Added logging for Helm command execution.
  • Updated k8s deployment file to remove unused DeepMerge dependency.
- Implemented a new `cert-manager` module for deploying cert-manager. - Added support for specifying a Helm repository in module configurations. - Introduced `cert_manager` module in `modules/mod.rs`. - Created `src/modules/cert_manager` directory and its associated code. - Implemented `add_repo` function in `src/modules/helm.rs` for adding Helm repositories. - Updated `LAMPInterpret` and `lamp.rs` to integrate the new module. - Added logging for Helm command execution. - Updated k8s deployment file to remove unused DeepMerge dependency.
johnride force-pushed feat/awsOKD from f281e01f29 to 4be008556e 2025-05-06 16:39:00 +00:00 Compare
johnride merged commit e5ddd296db into master 2025-05-06 16:39:19 +00:00
johnride deleted branch feat/awsOKD 2025-05-06 16:39:20 +00:00
taha reviewed 2025-05-06 16:45:13 +00:00
harmony/src/modules/helm/chart.rs
@@ -45,2 +64,4 @@
pub score: HelmChartScore,
}
impl HelmChartInterpret {
fn add_repo(&self) -> Result<(), InterpretError> {
taha commented 2025-05-06 16:45:13 +00:00
Collaborator
Copy Link

https://github.com/kubernetes-sigs/kustomize/blob/master/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go#L326

Could be simplified, without needing to manage repos through helm repo add etc

https://github.com/kubernetes-sigs/kustomize/blob/master/plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go#L326 Could be simplified, without needing to manage repos through `helm repo add` etc
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#31
No description provided.
Delete Branch "feat/awsOKD"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?