Many significant improvements worth doing, overall great progress and most stuff works nicely. At the moement this is a lot of new modules that are separated, share a common "style" but lack the magic binding them all together. Some are pretty high level like the HA OPNSense KVM demo tying most of the new stuff together but then the openbao / zitadel modules are not integrated with the rest yet.
This should not panic, just return a clear error. This will require some refactoring of this module.
This should be a score that leverages the phased topology approach : LinuxHostTopology -> KvmHostTopology
This feels a bit fragile, but I'm not very familiar with openbao. Is there an api we can call using the root token to provision the first user? Is there a rust crate for vault/openbao that would allow doing this type-safely?
Here this is a practical but very naive way to do that. We should be using harmony_config/secret but we have a chicken-and-egg problem where we want to use openbao as the secret store but it needs to be initialized first.
We should have a clean module to handle directories, not hardcode harmony everywhere.
Almost every time we ran this there was a longer delay than the default wait-for timeout (30 or 45 minutes iirc). We should take that into account.
This is a bit too opinionated at this level, we should let the score caller decide if he wants to expose them publicly.
Ideally this would be a specific type for KvmHost with the relevant validation logic and a macro to make it easy to hardcode it type-safely.