NationTech/harmony
3
0
Fork 2
Code Issues 38 Pull Requests 8 Actions Packages Projects Releases 1 Wiki Activity

fix: app-deploy safety — no secret helm dump, jwt mount, ingress, smoke #347

Open
johnride wants to merge 5 commits from fix/app-deploy-safety into master
pull from: fix/app-deploy-safety
merge into: NationTech:master
Conversation 0 Commits 5 Files Changed 43 +150 -320
johnride commented 2026-08-08 22:14:42 +00:00
Owner
Copy Link
  • Drop Zitadel Helm values trace (embeds admin password)
  • Honor OPENBAO_JWT_AUTH_MOUNT on assignment role read/write
  • Fail loud on unknown ingress endpoint instead of silent None
  • Gate smoke checks on rollout.readiness.wait
- Drop Zitadel Helm values trace (embeds admin password) - Honor OPENBAO_JWT_AUTH_MOUNT on assignment role read/write - Fail loud on unknown ingress endpoint instead of silent None - Gate smoke checks on rollout.readiness.wait
johnride added 1 commit 2026-08-08 22:14:43 +00:00
fix: app-deploy safety — no secret helm dump, jwt mount, ingress, smoke
All checks were successful
Run Check Script / check (pull_request) Successful in 1m52s
Details
633c9990a4 
- Drop Zitadel Helm values trace (embeds admin password)
- Honor OPENBAO_JWT_AUTH_MOUNT on assignment role read/write
- Fail loud on unknown ingress endpoint instead of silent None
- Gate smoke checks on rollout.readiness.wait
johnride added 4 commits 2026-08-08 23:59:17 +00:00
chore: clear compile warnings; retire SecretManager
Some checks failed
Run Check Script / check (pull_request) Failing after 2s
Details
3b2da4d6ff 
- Migrate callers from SecretManager to harmony_config::get_or_prompt
- Lazy-init global ConfigClient from HARMONY_SECRET_NAMESPACE
- Convert remaining Secret derives to Config + #[config(secret)]
- Remove deprecated SecretManager
- Retry::spawn → start; drop unused import; cfg-gate nm_bond_mode
- allow(deprecated) on legacy ApplicationScore examples
fix: format imports 7bd78c9ab5
feat: bump harmony composer docker rust version
All checks were successful
Run Check Script / check (pull_request) Successful in 1m51s
Details
3163d916b1
Merge pull request 'chore: clear compile warnings; retire SecretManager' (#346) from chore/clear-compile-warnings into fix/app-deploy-safety
All checks were successful
Run Check Script / check (pull_request) Successful in 1m44s
Details
010332a083 
Reviewed-on: #346
All checks were successful
Run Check Script / check (pull_request) Successful in 1m44s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/app-deploy-safety:fix/app-deploy-safety
git checkout fix/app-deploy-safety
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel reda stremblay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#347
No description provided.
Delete Branch "fix/app-deploy-safety"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?