NationTech/harmony
3
0
Fork 2
Code Issues 38 Pull Requests 8 Actions Packages Projects Releases 1 Wiki Activity

chore: clear compile warnings; retire SecretManager #346

Merged
johnride merged 3 commits from chore/clear-compile-warnings into fix/app-deploy-safety 2026-08-08 23:59:17 +00:00
Conversation 0 Commits 3 Files Changed 39 +119 -306
johnride commented 2026-08-08 22:14:30 +00:00
Owner
Copy Link
  • Migrate callers from SecretManager to harmony_config::get_or_prompt
  • Lazy-init global ConfigClient from HARMONY_SECRET_NAMESPACE
  • Convert remaining Secret derives to Config + #[config(secret)]
  • Remove deprecated SecretManager
  • Retry::spawn → start; drop unused import; cfg-gate nm_bond_mode
  • allow(deprecated) on legacy ApplicationScore examples
- Migrate callers from SecretManager to harmony_config::get_or_prompt - Lazy-init global ConfigClient from HARMONY_SECRET_NAMESPACE - Convert remaining Secret derives to Config + #[config(secret)] - Remove deprecated SecretManager - Retry::spawn → start; drop unused import; cfg-gate nm_bond_mode - allow(deprecated) on legacy ApplicationScore examples
johnride added 1 commit 2026-08-08 22:14:30 +00:00
chore: clear compile warnings; retire SecretManager
Some checks failed
Run Check Script / check (pull_request) Failing after 2s
Details
3b2da4d6ff 
- Migrate callers from SecretManager to harmony_config::get_or_prompt
- Lazy-init global ConfigClient from HARMONY_SECRET_NAMESPACE
- Convert remaining Secret derives to Config + #[config(secret)]
- Remove deprecated SecretManager
- Retry::spawn → start; drop unused import; cfg-gate nm_bond_mode
- allow(deprecated) on legacy ApplicationScore examples
johnride added 2 commits 2026-08-08 23:55:30 +00:00
fix: format imports 7bd78c9ab5
feat: bump harmony composer docker rust version
All checks were successful
Run Check Script / check (pull_request) Successful in 1m51s
Details
3163d916b1
johnride merged commit 010332a083 into fix/app-deploy-safety 2026-08-08 23:59:17 +00:00
johnride deleted branch chore/clear-compile-warnings 2026-08-08 23:59:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel reda stremblay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#346
No description provided.
Delete Branch "chore/clear-compile-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?