ea1380f98a
Merge pull request 'refact: Move basic types to harmony_types crate to avoid external dependencies.' (#126) from refact/harmony_types into feat/inventory_persistence
It seems useless but I'm not sure they should actually be merged: to me it feels like two different concepts with a different lifecycle. It is highlighted by the fact that the harmony_inventory_agent is a standalone service that could be consumed by other programs and that this inventory module here is just one of them. The inventory has its own representation of a PhysicalHost that might become different than the one from the harmony_inventory_agent.
I'll create an issue about this dependency injection problem we have in our Interprets (and at some extend the Scores statelessness).
Just sharing a thought even if it's not the most representative situation here (considering we're in the infra). Though it still indirectly highlights the underlying issue.
A garder un oeil si on aurait besoin de presenter ce summary de manieres differentes (e.g. fichier json). A ce moment-la, il pourrait etre interessant d'y aller avec le pattern de "presenter":
Could this struct evolve in time and that at some point we update an existing physical host instead of just saving a new one every time?
should we use the Id type instead of a str here?