NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

Better error handling for DiscoverInventoryAgentIntrepret #128

New Issue
Open
opened 2025-08-31 22:10:20 +00:00 by letian · 1 comment
letian commented 2025-08-31 22:10:20 +00:00
Owner
Copy Link

There's an edge case here that might break the DiscoverInventoryAgentInterpret:

discover_agents is awaited, but the spawned task inside the callback are not awaited at all. So in some edge cases, discover_agents might finish executing before the task itself.

And because we don't await for the task inside the callback, error handling is a bit awkward. Currently it says "all good" even though there could be an error:

[INFO ] Getting inventory for host 192.168.5.232 at port 8080

thread 'tokio-runtime-worker' panicked at /home/ian/Projects/nation-tech/harmony/harmony/src/modules/inventory/mod.rs:105:34:
called `Result::unwrap()` on an `Err` value: "Could not build repository : Could not connect to the database: error returned from database: (code: 14) unable to open database file"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[INFO ] ✅ Discovery process completed successfully

Originally posted by @letian in https://git.nationtech.io/NationTech/harmony/pulls/127/files#issuecomment-1987

There's an edge case here that might break the `DiscoverInventoryAgentInterpret`: `discover_agents` is awaited, but the _spawned_ task inside the callback are not awaited at all. So in some edge cases, `discover_agents` might finish executing before the task itself. And because we don't _await_ for the task inside the callback, error handling is a bit awkward. Currently it says "all good" even though there could be an error: ``` [INFO ] Getting inventory for host 192.168.5.232 at port 8080 thread 'tokio-runtime-worker' panicked at /home/ian/Projects/nation-tech/harmony/harmony/src/modules/inventory/mod.rs:105:34: called `Result::unwrap()` on an `Err` value: "Could not build repository : Could not connect to the database: error returned from database: (code: 14) unable to open database file" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace [INFO ] ✅ Discovery process completed successfully ``` _Originally posted by @letian in https://git.nationtech.io/NationTech/harmony/pulls/127/files#issuecomment-1987_
johnride commented 2025-09-01 17:36:51 +00:00
Owner
Copy Link

Yep I thought about renaming the score to LaunchDiscoveryAgentScore it would make it way more intuitive for the current behavior without having to refactor anything more.

Yep I thought about renaming the score to `LaunchDiscoveryAgentScore` it would make it way more intuitive for the current behavior without having to refactor anything more.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#128
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?