johnride
  • Joined on 2024-02-06
johnride commented on pull request NationTech/harmony#217 2026-01-22 20:39:28 +00:00
feat: Create st-test example, fix a couple new missing xml fields for opnsense, fix bad HostRole

Juste a enlever le fichier de notes et c'est bon pour moi 👍

johnride commented on pull request NationTech/harmony#217 2026-01-22 20:39:12 +00:00
feat: Create st-test example, fix a couple new missing xml fields for opnsense, fix bad HostRole

Remove from repo, belongs in an issue

johnride suggested changes for NationTech/harmony#211 2026-01-20 17:12:30 +00:00
feat/cert_manager_crds
johnride commented on pull request NationTech/harmony#211 2026-01-20 17:12:30 +00:00
feat/cert_manager_crds

else -> default namespace

johnride commented on pull request NationTech/harmony#211 2026-01-20 17:12:30 +00:00
feat/cert_manager_crds

Not the place

johnride pushed to feat/cert_manager_crds at NationTech/harmony 2026-01-20 17:11:53 +00:00
c3ac0bafad lint: Remove useless variable assignment
johnride pushed to feat/dockerAutoinstall at NationTech/harmony 2026-01-19 21:49:09 +00:00
dd6e36889b feat(tools): docker autoinstall checks with docker info now and calls rootless setup helper after install
johnride pushed to feat/dockerAutoinstall at NationTech/harmony 2026-01-19 20:27:51 +00:00
50b3995449 fix(tools): Skip checksum verification in docker script download
johnride created pull request NationTech/harmony#215 2026-01-19 17:06:23 +00:00
feat: Autoinstall docker
johnride pushed to feat/dockerAutoinstall at NationTech/harmony 2026-01-19 17:06:13 +00:00
8d27ecf6de feat: Autoinstall docker
johnride created branch feat/dockerAutoinstall in NationTech/harmony 2026-01-19 17:06:12 +00:00
johnride commented on pull request NationTech/harmony#211 2026-01-16 22:31:42 +00:00
feat/cert_manager_crds

We want to be able to create certificates on anything implementing CertificateManagement, not just kubernetes.

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

You should be using the CRD here, not crafting a GVK. See how it's done with NMstate and other CRDs.

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

I would have thought that CertificateScore depends on CertificateManagement capability, not the other way around.

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

This should not return PreparationError and PreparationOutcome.

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

It should be ensure_ready, no need for the long function name. Let's keep is standard-ish across Harmony. Eventually we will very likely extract the readiness state management in a separate trait.

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

Change the return types. This is something that will require cleanup across harmony eventually. But the semantic is incorrect here. This trait is not scoped in preparation.

johnride suggested changes for NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

Some refactoring to do, but not too far off!

johnride commented on pull request NationTech/harmony#211 2026-01-16 22:28:29 +00:00
feat/cert_manager_crds

If you were using the CRD properly here you would not have to mess with JSON, you would simply be walking the Rust struct directly.