Once again, this contains way too many implementation details. There should be a NatsK8s module that contains the nats specific logid, then k8s anywhere only does the dispatching depending on its own logic/state (which k8s is the anywhere pointing to right now). K8sAnywhere should not know how to deploy nats. It should tell a natsk8s module "deploy to okd" or something along those lines.
Good step in the right direction. I made comments as I read the code, it will probably require some discussion, unless everything I am saying really makes sense.
Delete this impl. These todo! are a huge smell. And I think it is fine that a decentralized topology does not know how to deploy nats asite of a NatsSupercluster. At least for the current use case. The end user deploying a postgresql will deploy it to a failovertopology, then the failovertopology will depend on a topology that supports a natssupercluster. At least for now.
This does not belong in this file or as part of an impl K8sAnywhereTopology .
Don't duplicate an identical match arm, rust allows a single body for multiple match cases. Look up the syntax if needed.
This retry logic does not belong within the get_ca_cert function.
cb90788129
Merge pull request 'fix(deps): updating fqdn version as the one currently in use have been yanked' (#223) from fix/update-fqdn-version into master
e557270960
Merge pull request 'feat/ask-for-main-disk' (#222) from feat/ask-for-main-disk into master
54320e2ebe
chore: refactor PhysicalHost into a tuple with HostConfig, it contains only installation device for now but it saves some mishaps
54320e2ebe
chore: refactor PhysicalHost into a tuple with HostConfig, it contains only installation device for now but it saves some mishaps
5b227408f6
chore: refactor PhysicalHost into a tuple with HostConfig, it contains only installation device for now but it saves some mishaps