johnride
  • Joined on 2024-02-06
johnride approved NationTech/harmony#183 2025-11-05 21:30:24 +00:00
refactor(host_network): extract NetworkManager as a reusable component

Overall LGTM, a few considerations here and there but nothing major.

johnride commented on pull request NationTech/harmony#183 2025-11-05 21:30:24 +00:00
refactor(host_network): extract NetworkManager as a reusable component

url::parse can fail at runtime, would hurl! work here?

johnride commented on pull request NationTech/harmony#183 2025-11-05 21:30:24 +00:00
refactor(host_network): extract NetworkManager as a reusable component

I guess this is required because the operator from the catalog does not work?

johnride commented on pull request NationTech/harmony#183 2025-11-05 21:30:24 +00:00
refactor(host_network): extract NetworkManager as a reusable component

I really don't like the boilerplate added by having multiple error types for each bit of business logic.

johnride commented on pull request NationTech/harmony#183 2025-11-05 21:30:24 +00:00
refactor(host_network): extract NetworkManager as a reusable component

Why is this function and logic in ha_cluster instead of network manager?

johnride commented on pull request NationTech/harmony#183 2025-11-05 21:30:23 +00:00
refactor(host_network): extract NetworkManager as a reusable component

Why OnceLock instead of Oncecell or something else? I'm not familiar with it. I guess it takes a read lock when accessed after initialization?

johnride commented on pull request NationTech/harmony#182 2025-11-05 20:48:28 +00:00
fix(host_network): retrieve proper hostname and next available bond id

Rust is so beautiful. Type K infered from return type, completely transparent, super powerful, super readable, super intuitive.

johnride approved NationTech/harmony#182 2025-11-05 20:48:28 +00:00
fix(host_network): retrieve proper hostname and next available bond id

LGTM, just make sure the bond checking logic is correct.

johnride commented on pull request NationTech/harmony#182 2025-11-05 20:48:28 +00:00
fix(host_network): retrieve proper hostname and next available bond id

Why type Bond AND link_aggregation ?

johnride created pull request NationTech/harmony#184 2025-11-05 15:03:27 +00:00
feat: OPNSense Topology useful to interact with only an opnsense instance.
johnride pushed to feat/opnsenseTopology at NationTech/harmony 2025-11-05 15:03:06 +00:00
7b542c9865 feat: OPNSense Topology useful to interact with only an opnsense instance.
johnride created branch feat/opnsenseTopology in NationTech/harmony 2025-11-05 15:03:06 +00:00
johnride pushed to feat/cluster_monitoring at NationTech/harmony 2025-10-30 03:12:37 +00:00
cf84f2cce8 wip: cluster_monitoring almost there, a kink to fix in the yaml handling
johnride pushed to feat/cluster_monitoring at NationTech/harmony 2025-10-29 21:29:40 +00:00
a12d12aa4f feat: example OpenshiftClusterAlertScore
johnride created pull request NationTech/harmony#180 2025-10-29 21:27:46 +00:00
feat(kube): Utility function to convert kube_openapi Resource to DynamicObject. This will allow initializing resources strongly typed and then bundle various types into a list of DynamicObject
johnride created pull request NationTech/harmony#179 2025-10-29 21:27:10 +00:00
feat/cluster_monitoring
johnride pushed to feat/cluster_monitoring at NationTech/harmony 2025-10-29 21:26:54 +00:00
e8968d2cd2 feat: example OpenshiftClusterAlertScore
cefb65933a wip: cluster monitoring score coming along, this simply edits OKD builtin alertmanager instance and adds a receiver
Compare 2 commits »
johnride created branch feat/cluster_monitoring in NationTech/harmony 2025-10-29 21:26:53 +00:00
johnride pushed to feat/kube_convert_dynamic_resource at NationTech/harmony 2025-10-29 21:24:41 +00:00
95cfc03518 feat(kube): Utility function to convert kube_openapi Resource to DynamicObject. This will allow initializing resources strongly typed and then bundle various types into a list of DynamicObject
johnride created branch feat/kube_convert_dynamic_resource in NationTech/harmony 2025-10-29 21:24:40 +00:00