NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

fix: make HelmRepository public #39

Merged
taha merged 1 commits from public-helm-repo into master 2025-05-22 20:07:43 +00:00
Conversation 4 Commits 1 Files Changed 1 +5 -2
taha commented 2025-05-22 12:51:24 +00:00
Collaborator
Copy Link
No description provided.
taha added 1 commit 2025-05-22 12:51:25 +00:00
fix: make HelmRepository public e6d1f4f630
johnride requested changes 2025-05-22 20:04:50 +00:00
johnride left a comment
Owner
Copy Link

I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here?

I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here?
taha commented 2025-05-22 20:05:41 +00:00
Author
Collaborator
Copy Link

I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here?

It's exposed through the score, and if a score needs a repo, it can't make one

> I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here? It's exposed through the score, and if a score needs a repo, it can't make one
johnride commented 2025-05-22 20:07:05 +00:00
Owner
Copy Link

I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here?

It's exposed through the score, and if a score needs a repo, it can't make one

Makes sense, got it. Sorry!

> > I feel like this should not be public. Our public APIs should go through Scores, Topologies and Inventories. What's the reasonning here? > > It's exposed through the score, and if a score needs a repo, it can't make one Makes sense, got it. Sorry!
johnride approved these changes 2025-05-22 20:07:16 +00:00
taha merged commit 76ae5eb747 into master 2025-05-22 20:07:43 +00:00
taha deleted branch public-helm-repo 2025-05-22 20:07:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
johnride
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#39
No description provided.
Delete Branch "public-helm-repo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?