NationTech/harmony
6
0
Fork 1
Code Issues 35 Pull Requests 6 Actions Packages Projects Releases 1 Wiki Activity

fix(composer): spawn commands to allow interaction #71

Merged
letian merged 2 commits from fix/harmony-compose-deploy-output into master 2025-07-01 21:08:27 +00:00
Conversation 2 Commits 2 Files Changed 1 +15 -16
letian commented 2025-07-01 20:34:32 +00:00
Owner
Copy Link

Using Command::output() executes the command and wait for it to be finished before returning the output.
For the deploy command, the user might need to interact with the CLI before continuing, which hangs the command execution.

Instead, using Command::spawn() allows to forward stdin/stdout to the parent process.

Using `Command::output()` executes the command and wait for it to be finished before returning the output. For the `deploy` command, the user might need to interact with the CLI before continuing, which hangs the command execution. Instead, using `Command::spawn()` allows to forward stdin/stdout to the parent process.
letian added 1 commit 2025-07-01 20:34:40 +00:00
fix(harmony-composer): spawn deploy command to allow interaction
All checks were successful
Run Check Script / check (pull_request) Successful in 1m46s
Details
0861700231
letian changed title from fix(harmony-composer): spawn deploy command to allow interaction to fix(composer): spawn deploy command to allow interaction 2025-07-01 20:34:55 +00:00
letian commented 2025-07-01 20:39:58 +00:00
Author
Owner
Copy Link

Should we apply right away the same fix for the other commands and use spawn instead of output in case users would need to interact with some of the commands?

Should we apply right away the same fix for the other commands and use `spawn` instead of `output` in case users would need to interact with some of the commands?
johnride approved these changes 2025-07-01 20:40:54 +00:00
johnride commented 2025-07-01 20:42:09 +00:00
Owner
Copy Link

Should we apply right away the same fix for the other commands and use spawn instead of output in case users would need to interact with some of the commands?

I don't see why not, go for it!

> Should we apply right away the same fix for the other commands and use `spawn` instead of `output` in case users would need to interact with some of the commands? I don't see why not, go for it!
letian changed title from fix(composer): spawn deploy command to allow interaction to fix(composer): spawn commands to allow interaction 2025-07-01 21:05:10 +00:00
letian added 1 commit 2025-07-01 21:05:31 +00:00
replace check command output by spawn
All checks were successful
Run Check Script / check (pull_request) Successful in 1m33s
Details
8419815c0a
letian merged commit ee02906ce9 into master 2025-07-01 21:08:27 +00:00
letian deleted branch fix/harmony-compose-deploy-output 2025-07-01 21:09:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
johnride
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#71
No description provided.
Delete Branch "fix/harmony-compose-deploy-output"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?