NationTech/harmony
3
0
Fork 2
Code Issues 38 Pull Requests 29 Actions Packages Projects Releases 1 Wiki Activity

refactor(fleet-deploy): rename HARMONY_SECRET_NAMESPACE to HARMONY_CONFIG_NAMESPACE #314

Merged
johnride merged 2 commits from refactor/config-namespace-env-var into feat/fleet-staging-openbao 2026-06-01 15:42:35 +00:00
Conversation 0 Commits 2 Files Changed 3 +19 -12
johnride commented 2026-05-31 14:12:03 +00:00
Owner
Copy Link

The env var name was a misnomer — ConfigClient resolves both config and
secrets, not just secrets. The struct field was already config_namespace.
Legacy SecretManager keeps the old var; this forces migration to
ConfigClient for new code.

The env var name was a misnomer — ConfigClient resolves both config and secrets, not just secrets. The struct field was already config_namespace. Legacy SecretManager keeps the old var; this forces migration to ConfigClient for new code.
johnride added 1 commit 2026-05-31 14:12:04 +00:00
refactor(fleet-deploy): rename HARMONY_SECRET_NAMESPACE to HARMONY_CONFIG_NAMESPACE
Some checks failed
Run Check Script / check (pull_request) Failing after 51s
Details
f7299ebe2b 
The env var name was a misnomer — ConfigClient resolves both config and
secrets, not just secrets. The struct field was already config_namespace.
Legacy SecretManager keeps the old var; this forces migration to
ConfigClient for new code.
johnride added 1 commit 2026-05-31 14:14:30 +00:00
fix(openbao): remove extra blank line in example
All checks were successful
Run Check Script / check (pull_request) Successful in 2m26s
Details
2e9052b217 
Pre-existing formatting issue caught by cargo fmt --check.
johnride merged commit 5c2e1fa401 into feat/fleet-staging-openbao 2026-06-01 15:42:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel reda stremblay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#314
No description provided.
Delete Branch "refactor/config-namespace-env-var"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?