NationTech/harmony
3
0
Fork 2
Code Issues 38 Pull Requests 29 Actions Packages Projects Releases 1 Wiki Activity

feat(example-harmony-sso): example aligned to AGENTS.md minimalism bar #311

Open
stremblay wants to merge 1 commits from pr/harmony-sso-example into master
pull from: pr/harmony-sso-example
merge into: NationTech:master
Conversation 0 Commits 1 Files Changed 3 +173 -140
stremblay commented 2026-05-29 20:47:32 +00:00
Owner
Copy Link

Summary

Final piece of the 4-PR split: brings examples/harmony_sso/ onto current master, trimmed to the new AGENTS.md minimalism bar.

Changes

  • main.rs — drop multi-paragraph docstrings, WHAT-narration, ASCII section dividers; factor the duplicated OpenbaoSetupScore literal into openbao_setup(jwt: Option<OpenbaoJwtAuth>); add SAFETY note on the
    create_topology unsafe set_var block.
  • README.md — drop doc-rotted --demo / --sso-demo sections (flags don't exist in main.rs), drop the duplicated Notes section restating HMAC/identity, tighten audit prose to operator instructions.
  • harmony_sso_plan.md — unchanged. The "Tricky Things / Lessons Learned" notes (Zitadel k3d quirks, CNPG race, Host-header gotchas) are real institutional knowledge not derivable from code; churning the planning
    doc is itself bloat.

Runtime behaviour identical to the validated integration branch.

Trim

  • main.rs: 509 → 423 lines (-17%)
  • README.md: 181 → 113 lines (-38%)

Verification

cargo check --workspace --all-targets --all-features, cargo fmt --check, cargo clippy -p example-harmony-sso, cargo test -p example-harmony-sso — all clean. The clippy warnings appearing at the workspace level
are pre-existing in harmony lib on master, unrelated to this PR.

## Summary Final piece of the 4-PR split: brings `examples/harmony_sso/` onto current master, trimmed to the new AGENTS.md minimalism bar. ## Changes - **`main.rs`** — drop multi-paragraph docstrings, WHAT-narration, ASCII section dividers; factor the duplicated `OpenbaoSetupScore` literal into `openbao_setup(jwt: Option<OpenbaoJwtAuth>)`; add SAFETY note on the `create_topology` unsafe `set_var` block. - **`README.md`** — drop doc-rotted `--demo` / `--sso-demo` sections (flags don't exist in `main.rs`), drop the duplicated Notes section restating HMAC/identity, tighten audit prose to operator instructions. - **`harmony_sso_plan.md`** — unchanged. The "Tricky Things / Lessons Learned" notes (Zitadel k3d quirks, CNPG race, Host-header gotchas) are real institutional knowledge not derivable from code; churning the planning doc is itself bloat. Runtime behaviour identical to the validated integration branch. ## Trim - `main.rs`: 509 → 423 lines (-17%) - `README.md`: 181 → 113 lines (-38%) ## Verification `cargo check --workspace --all-targets --all-features`, `cargo fmt --check`, `cargo clippy -p example-harmony-sso`, `cargo test -p example-harmony-sso` — all clean. The clippy warnings appearing at the workspace level are pre-existing in `harmony` lib on master, unrelated to this PR.
stremblay added 1 commit 2026-05-29 20:47:33 +00:00
feat(example-harmony-sso): example aligned to AGENTS.md minimalism bar
All checks were successful
Run Check Script / check (pull_request) Successful in 2m37s
Details
4eee06a1f2 
Ports examples/harmony_sso/ onto current master, trimmed to the new bar:
- main.rs: drop multi-paragraph docstrings, WHAT-narration, ASCII
  section dividers; factor the duplicated OpenbaoSetupScore literal
  into openbao_setup(jwt: Option<OpenbaoJwtAuth>); add SAFETY note on
  the second unsafe set_var block
- README.md: drop doc-rotted --demo / --sso-demo sections (flags don't
  exist), drop duplicated HMAC/identity Notes section, tighten audit
  prose
- harmony_sso_plan.md unchanged (Lessons Learned are real institutional
  knowledge not derivable from code)

Same end-to-end runtime behaviour as the validated integration branch.
PR 4 of 4 splitting feat/unified-config-and-secrets.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
All checks were successful
Run Check Script / check (pull_request) Successful in 2m37s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin pr/harmony-sso-example:pr/harmony-sso-example
git checkout pr/harmony-sso-example
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel reda stremblay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#311
No description provided.
Delete Branch "pr/harmony-sso-example"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?