NationTech/harmony
5
0
Fork 2
Code Issues 40 Pull Requests 12 Actions 3 Packages Projects Releases Wiki Activity

WIP: feat: brocade module now supports vlans #255

Draft
stremblay wants to merge 9 commits from feat/brocade-client-add-vlans into master
pull from: feat/brocade-client-add-vlans
merge into: NationTech:master
Conversation 1 Commits 9 Files Changed 19 +1178 -139
stremblay commented 2026-03-24 19:27:10 +00:00
Owner
Copy Link
No description provided.
stremblay added 1 commit 2026-03-24 19:27:11 +00:00
feat: brocade module now support vlans
Some checks failed
Run Check Script / check (pull_request) Failing after 27s
Details
6237e1d877
stremblay added 1 commit 2026-03-24 19:48:21 +00:00
fix: use Vlan struct instance everywhere, never use an u16 to reference a Vlan
Some checks failed
Run Check Script / check (pull_request) Failing after 26s
Details
b67275662d
stremblay added 1 commit 2026-03-25 13:21:16 +00:00
feat: require to specify port-channel ID instead of finding an available one
Some checks failed
Run Check Script / check (pull_request) Failing after 24s
Details
7422534018
stremblay added 1 commit 2026-03-25 13:35:15 +00:00
set the description of the port-channel interface
Some checks failed
Run Check Script / check (pull_request) Failing after 28s
Details
d8dab12834
stremblay added 1 commit 2026-03-25 13:59:01 +00:00
feat: add a 'reset_interface' function
Some checks failed
Run Check Script / check (pull_request) Failing after 24s
Details
a1c9bfeabd
stremblay added 1 commit 2026-03-25 15:46:05 +00:00
feat: create new brocade configuration score
Some checks failed
Run Check Script / check (pull_request) Failing after 24s
Details
8c8baaf9cc
stremblay added 1 commit 2026-03-25 16:10:44 +00:00
feat: add possibility to configure interface speed
Some checks failed
Run Check Script / check (pull_request) Failing after 26s
Details
2728fc8989
stremblay added 1 commit 2026-03-25 16:35:59 +00:00
feat: use an enum for interface types, add logging
Some checks failed
Run Check Script / check (pull_request) Failing after 23s
Details
a646f1f4d0
johnride approved these changes 2026-03-25 16:57:42 +00:00
johnride left a comment
Owner
Copy Link

LGTM

LGTM
johnride changed target branch from feat/opnsense-codegen to master 2026-04-09 21:05:16 +00:00
stremblay added 1 commit 2026-04-10 19:41:48 +00:00
fix: when creating a port-channel with forced speed, it needs to be set on the port-channel and its member interfaces
Some checks failed
Run Check Script / check (pull_request) Failing after 11m29s
Details
fb72e94dbb
Some checks failed
Run Check Script / check (pull_request) Failing after 11m29s
Details
This pull request has changes conflicting with the target branch.
  • build/check.sh
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/brocade-client-add-vlans:feat/brocade-client-add-vlans
git checkout feat/brocade-client-add-vlans
Sign in to join this conversation.
Reviewers
No Reviewers
johnride
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#255
No description provided.
Delete Branch "feat/brocade-client-add-vlans"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?