NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 6 Actions 7 Packages Projects Releases 1 Wiki Activity

feat(HelmScore): Add values yaml option to helm chart score #23

Merged
taha merged 3 commits from add-helm-values-yaml into master 2025-04-29 16:09:05 +00:00
Conversation 0 Commits 3 Files Changed 3 +51 -29
taha commented 2025-04-29 15:51:04 +00:00
Collaborator
Copy Link
No description provided.
taha added 2 commits 2025-04-29 15:51:05 +00:00
johnride requested changes 2025-04-29 15:55:10 +00:00
harmony/src/modules/helm/chart.rs
@ -49,2 +52,4 @@
.as_ref()
.unwrap_or_else(|| todo!("Get namespace from active kubernetes cluster"));
let mut yaml_path: Option<&Path> = None;
johnride commented 2025-04-29 15:54:41 +00:00
Owner
Copy Link

No need for a mut here. This would be more readable as a match :

let yaml_path = match self.score.values_yaml {
  Some(yaml) => { temp_file... do the work }
  None => None
};
No need for a mut here. This would be more readable as a match : ```rust let yaml_path = match self.score.values_yaml { Some(yaml) => { temp_file... do the work } None => None }; ```
taha added 1 commit 2025-04-29 16:02:36 +00:00
taha merged commit 254f392cb5 into master 2025-04-29 16:09:05 +00:00
taha deleted branch add-helm-values-yaml 2025-04-29 16:09:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
johnride
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#23
No description provided.
Delete Branch "add-helm-values-yaml"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?