NationTech/harmony
5
0
Fork 2
Code Issues 40 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

fix: use installation_device from host_config in bootstrap_okd_node #228

Merged
stremblay merged 3 commits from fix/installation-device-for-nodes-in-byMAC into master 2026-02-05 22:38:01 +00:00
Conversation 2 Commits 3 Files Changed 2 +40 -13
stremblay commented 2026-02-05 22:00:02 +00:00
Owner
Copy Link

The fix was done only in bootstrap_02_bootstrap.rs, I also applied it in bootstrap_ok_node.rs

The fix was done only in `bootstrap_02_bootstrap.rs`, I also applied it in `bootstrap_ok_node.rs`
stremblay added 1 commit 2026-02-05 22:00:03 +00:00
fix: use installation_device from host_config in bootstrap_okd_node
All checks were successful
Run Check Script / check (pull_request) Successful in 1m11s
Details
d6ddbfa51a
stremblay added 1 commit 2026-02-05 22:04:59 +00:00
fix: satisfy my ocd :)
All checks were successful
Run Check Script / check (pull_request) Successful in 1m8s
Details
83459eb2a6
johnride reviewed 2026-02-05 22:11:42 +00:00
harmony/src/modules/okd/bootstrap_okd_node.rs Outdated
@@ -210,0 +209,4 @@
))
},
)?,
ignition_file_name: ignition_file_name,
johnride commented 2026-02-05 22:11:42 +00:00
Owner
Copy Link

shorthand this

shorthand this
stremblay commented 2026-02-05 22:30:32 +00:00
Author
Owner
Copy Link

indeed, pi http_ip aussi ...! :)

indeed, pi http_ip aussi ...! :)
johnride commented 2026-02-05 22:12:31 +00:00
Owner
Copy Link

LGTM

LGTM
stremblay added 1 commit 2026-02-05 22:29:16 +00:00
fix: shorthand
All checks were successful
Run Check Script / check (pull_request) Successful in 1m10s
Details
7cd3c8b93d
stremblay merged commit 84992b7ada into master 2026-02-05 22:38:01 +00:00
stremblay deleted branch fix/installation-device-for-nodes-in-byMAC 2026-02-05 22:38:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#228
No description provided.
Delete Branch "fix/installation-device-for-nodes-in-byMAC"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?