NationTech/harmony
5
0
Fork 2
Code Issues 40 Pull Requests 13 Actions Packages Projects Releases Wiki Activity

feat: use interactive_parse lib to query for secrets attributes values #219

Merged
stremblay merged 5 commits from feat/json-attributes-prompt into master 2026-01-26 15:54:05 +00:00
Conversation 1 Commits 5 Files Changed 21 +135 -57
stremblay commented 2026-01-23 14:01:43 +00:00
Owner
Copy Link
No description provided.
stremblay added 1 commit 2026-01-23 14:01:44 +00:00
feat: use interactive_parse lib to query for secrets attributes values
All checks were successful
Run Check Script / check (pull_request) Successful in 1m20s
Details
9c6b780634
johnride requested changes 2026-01-23 15:17:00 +00:00
harmony_secret/src/lib.rs
@@ -116,2 +121,4 @@
let prompted = secret.is_err();
/*
let toto: T = T::parse_to_obj().expect("Failed to parse interactively");
johnride commented 2026-01-23 15:16:38 +00:00
Owner
Copy Link

cleanup

cleanup
harmony_secret/src/lib.rs Outdated
@@ -123,0 +144,4 @@
/*
let secret = secret.or_else(|e| -> Result<T, SecretStoreError> {
debug!("Could not get secret : {e}");
johnride commented 2026-01-23 15:16:58 +00:00
Owner
Copy Link

cleanup

cleanup
stremblay added 1 commit 2026-01-26 15:38:34 +00:00
Merge branch 'master' into feat/json-attributes-prompt
All checks were successful
Run Check Script / check (pull_request) Successful in 1m17s
Details
ce53ae0e04
stremblay added 1 commit 2026-01-26 15:43:55 +00:00
chore: remove useless comments
All checks were successful
Run Check Script / check (pull_request) Successful in 1m14s
Details
95f860809e
stremblay added 1 commit 2026-01-26 15:47:46 +00:00
chore: remove useless comments
Some checks failed
Run Check Script / check (pull_request) Failing after 15s
Details
25d5aff158
stremblay added 1 commit 2026-01-26 15:50:22 +00:00
chore: formatting
All checks were successful
Run Check Script / check (pull_request) Successful in 1m15s
Details
565bb4afa1
stremblay merged commit 8ae38399b7 into master 2026-01-26 15:54:05 +00:00
stremblay deleted branch feat/json-attributes-prompt 2026-01-26 15:54:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
johnride
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#219
No description provided.
Delete Branch "feat/json-attributes-prompt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?