fix: modified cert-manager ensure ready to check for existence of pods with labels matching cert-manager in kubernetes env. replaced deprecated olm subscription based install of cert-manager for supported helm-chart #218

Merged
wjro merged 2 commits from fix/cert-manager into master 2026-01-23 16:28:34 +00:00
Owner
No description provided.
wjro added 1 commit 2026-01-22 20:56:49 +00:00
johnride requested changes 2026-01-23 15:32:49 +00:00
@@ -928,0 +937,4 @@
}
/// Gets all resources of type K accross all namespaces
pub async fn get_all_resource<K>(&self) -> Result<Vec<K>, Error>
Owner

Remove comment and make name more explicit

Remove comment and make name more explicit
@@ -404,0 +398,4 @@
.map_err(|e| ExecutorError::UnexpectedError(format!("{}", e)))?;
if pods.is_empty() {
trace!("cert-manager not installed (no controller pods found)");
Owner

should be info since this has a major implication of installing a full thing

should be info since this has a major implication of installing a full thing
@@ -404,0 +401,4 @@
trace!("cert-manager not installed (no controller pods found)");
self.install().await
} else {
trace!("cert-manager controller pods found: {:#?}", pods);
Owner

Add another log at info level to inform that cert-manager is found

Add another log at info level to inform that cert-manager is found
@@ -63,0 +70,4 @@
// let metadata = ObjectMeta {
// name: Some("cert-manager".to_string()),
// namespace: Some(self.namespace.clone()),
// ..ObjectMeta::default()
Owner

cleanup

cleanup
wjro added 1 commit 2026-01-23 16:26:41 +00:00
fix: improved logging and function names for clarity
All checks were successful
Run Check Script / check (pull_request) Successful in 1m17s
d0cd21c322
wjro merged commit 33476e899e into master 2026-01-23 16:28:34 +00:00
wjro deleted branch fix/cert-manager 2026-01-23 16:28:35 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#218
No description provided.