NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

feat: K8sFlavour #161

Merged
wjro merged 7 commits from feat/detect_k8s_flavour into master 2025-10-21 15:56:48 +00:00
Conversation 0 Commits 7 Files Changed 2 +55 -5
wjro commented 2025-09-24 17:33:28 +00:00
Owner
Copy Link

Added K8sFlavour to K8sAnywhereTopology to be able to store and use the underlying Kubernetes implementation

Added K8sFlavour to K8sAnywhereTopology to be able to store and use the underlying Kubernetes implementation
wjro added 1 commit 2025-09-24 17:33:29 +00:00
feat:added k8s flavour to k8s_aywhere topology to be able to get the type of cluster
All checks were successful
Run Check Script / check (pull_request) Successful in 33s
Details
f073b7e5fb
johnride requested changes 2025-09-29 12:55:40 +00:00
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@ -49,1 +49,4 @@
#[derive(Debug, Clone)]
pub enum K8sFlavour {
Okd,
johnride commented 2025-09-29 12:52:41 +00:00
Owner
Copy Link

Should be OpenshiftFamily(Version) as we want the same behavior between okd and openshift.

Should be OpenshiftFamily(Version) as we want the same behavior between okd and openshift.
wjro marked this conversation as resolved
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@ -177,0 +210,4 @@
version
.git_version
.contains("k3s")
.then_some(K8sFlavour::K3d)
johnride commented 2025-09-29 12:54:14 +00:00
Owner
Copy Link

That is a clear naming problem. Should be either k3d for real by detecting it another way or k3sFamily just like OpenshiftFamily

That is a clear naming problem. Should be either k3d for real by detecting it another way or k3sFamily just like OpenshiftFamily
wjro marked this conversation as resolved
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@ -177,0 +220,4 @@
&& !version.git_version.contains("k3s")
&& !version.git_version.contains("k3d")
{
Some(K8sFlavour::K8s)
johnride commented 2025-09-29 12:55:19 +00:00
Owner
Copy Link

This is more of a fallback to a default than a true way to detect that we're running vanilla k8s (made by kubeadm for example).

Should be called Default or Fallback or Unknown but not k8s.

This is more of a fallback to a default than a true way to detect that we're running vanilla k8s (made by kubeadm for example). Should be called Default or Fallback or Unknown but not k8s.
wjro marked this conversation as resolved
johnride added 1 commit 2025-10-02 21:14:35 +00:00
Merge branch 'master' into feat/detect_k8s_flavour
All checks were successful
Run Check Script / check (pull_request) Successful in 1m20s
Details
5f78300d78
wjro added 1 commit 2025-10-21 15:02:17 +00:00
Merge branch 'master' into feat/detect_k8s_flavour
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
20a227bb41
wjro added 1 commit 2025-10-21 15:10:05 +00:00
fix: naming of k8s distribution
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
2a48d51479
wjro added 1 commit 2025-10-21 15:56:21 +00:00
Merge branch 'master' into feat/detect_k8s_flavour
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
2a520a1d7c
wjro merged commit 7f415f5b98 into master 2025-10-21 15:56:48 +00:00
wjro deleted branch feat/detect_k8s_flavour 2025-10-21 15:56:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
johnride
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#161
No description provided.
Delete Branch "feat/detect_k8s_flavour"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?