NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

fix: added securityContext.runAsUser:null to argo-cd helm chart so that in okd user group will be randomly assigned within the uid range for the designated namespace #156

Merged
wjro merged 2 commits from fix/argo-cd-redis into master 2025-09-12 13:54:03 +00:00
Conversation 1 Commits 2 Files Changed 2 +11 -9
wjro commented 2025-09-12 13:30:17 +00:00
Owner
Copy Link
No description provided.
wjro added 1 commit 2025-09-12 13:30:18 +00:00
letian reviewed 2025-09-12 13:33:06 +00:00
harmony/src/modules/prometheus/rhob_alerting_score.rs Outdated
@ -94,7 +86,6 @@ impl<T: Topology + K8sclient + Ingress + PrometheusApplicationMonitoring<RHOBObs
self.ensure_grafana_operator().await?;
self.install_prometheus(inventory, topology, &client)
.await?;
self.install_client_kube_metrics().await?;
letian commented 2025-09-12 13:33:05 +00:00
Owner
Copy Link

Is this deletion expected? Did it have any impact on the issue? Is it leaving any deadcode behind (is install_client_kube_metrics still used)?

Is this deletion expected? Did it have any impact on the issue? Is it leaving any deadcode behind (is `install_client_kube_metrics` still used)?
wjro commented 2025-09-12 13:52:45 +00:00
Author
Owner
Copy Link

This deletion was not expected, I was testing to see if having the namespaced kube-metrics deployment was necessary while using the cluster observability operator. With out current set up it is, since we deploy a service monitor that watches the kube-metrics, rather than a pod monitor or similar for each deployment/service that is created.

This deletion was not expected, I was testing to see if having the namespaced kube-metrics deployment was necessary while using the cluster observability operator. With out current set up it is, since we deploy a service monitor that watches the kube-metrics, rather than a pod monitor or similar for each deployment/service that is created.
letian commented 2025-09-12 13:38:20 +00:00
Owner
Copy Link

LGTM

Just a quick suggestion: for the PR title, try to describe what you are fixing (e.g. fix(argo-cd): auto assign user group for namespace) and then in your description add more details (what was the issue/ref to the issue, how you fixed it and why you did it that way - if applicable). No need to be too verbose though.

LGTM Just a quick suggestion: for the PR title, try to describe what you are fixing (e.g. `fix(argo-cd): auto assign user group for namespace`) and then in your description add more details (what was the issue/ref to the issue, how you fixed it and why you did it that way - if applicable). No need to be too verbose though.
wjro added 1 commit 2025-09-12 13:49:29 +00:00
fix(monitoring): returned namespaced kube metrics
All checks were successful
Run Check Script / check (pull_request) Successful in 55s
Details
f83fd09f11
wjro merged commit c84b2413ed into master 2025-09-12 13:54:03 +00:00
wjro deleted branch fix/argo-cd-redis 2025-09-12 13:54:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#156
No description provided.
Delete Branch "fix/argo-cd-redis"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?