NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

fix: remove indicatif in harmony_cli to simplify logging and fixing interactions #109

Merged
johnride merged 1 commits from rip-indicatif into master 2025-08-15 20:01:22 +00:00
Conversation 1 Commits 1 Files Changed 4 +122 -134
letian commented 2025-08-15 15:31:37 +00:00
Owner
Copy Link
  • remove indicatif in harmony_cli
  • interactivity works once again
  • create a custom log formatter
    • in default level (INFO) strip down noisy information (timestamp, file/target, etc.)
    • in debug and more, keep extra context
    • use structured log to make things a tiny bit more cute
  • keep indicatif in harmony_composer as it doesn't bother much

Default mode (info)

See attached gif

Debug mode

image

Within Harmony Composer

Note: prompt isn't shown here because of the --yes flag
image

* remove indicatif in harmony_cli * interactivity works once again * create a custom log formatter * in default level (INFO) strip down noisy information (timestamp, file/target, etc.) * in debug and more, keep extra context * use structured log to make things a tiny bit more cute * keep indicatif in harmony_composer as it doesn't bother much ## Default mode (info) See attached gif ## Debug mode ![image](/attachments/f149039f-7c8c-47a9-9fea-8b1a62834164) ## Within Harmony Composer _Note: prompt isn't shown here because of the `--yes` flag_ ![image](/attachments/4016df50-13ee-4ba7-b108-46c56ba1361e)
demo.gif
989 KiB
image.png
494 KiB
image.png
867 KiB
demo.gif
letian added 1 commit 2025-08-15 15:31:41 +00:00
fix: remove indicatif in harmony_cli to simplify logging and fixing interactions
All checks were successful
Run Check Script / check (pull_request) Successful in 1m7s
Details
8bb4a9d3f6
johnride commented 2025-08-15 20:00:58 +00:00
Owner
Copy Link

LGTM, petit glitch quand il y a des prompt mais on peut regler ca plus tard

image
LGTM, petit glitch quand il y a des prompt mais on peut regler ca plus tard <img width="1322" alt="image" src="attachments/dd233c61-714f-4b45-8a12-328e139825cc">
image.png
134 KiB
johnride merged commit 7d027bcfc4 into master 2025-08-15 20:01:22 +00:00
johnride deleted branch rip-indicatif 2025-08-15 20:01:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#109
No description provided.
Delete Branch "rip-indicatif"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?