Finish ADR proposal
This commit is contained in:
parent
564c00660b
commit
26d945f54a
@ -20,33 +20,42 @@ In order to move quickly and efficiently, Harmony should handle Helm charts simi
|
||||
|
||||
## Rationale
|
||||
|
||||
A lot of Helm's features aren't strictly necessary and would add unneeded overhead. This is likely the fastest way to go from zero to deployed. Other tools (e.g. Kustomize) already do this. Kustomize has tooling for patching and modifying k8s manifests before deploying, and Harmony should have that power too, even if it's not what Helm typically intends.
|
||||
|
||||
Perhaps in future also have a Kustomize resource in Harmony? Which could handle Helm charts for Harmony as well/instead.
|
||||
|
||||
## Consequences
|
||||
|
||||
Pros:
|
||||
**Pros**:
|
||||
|
||||
- Much easier (and faster) than implementing all of Helm's featureset
|
||||
- Re-use code from K8sResource already present in Harmony
|
||||
- Can potentially re-use code from K8sResource already present in Harmony
|
||||
- Harmony retains more control over how the deployment goes after rendering (i.e. can act like Kustomize, or leverage Kustomize itself to modify deployments after rendering/inflation)
|
||||
- Reduce (unstable) surface of dealing with Helm binary
|
||||
|
||||
Cons:
|
||||
**Cons**:
|
||||
|
||||
- Lose some Helm functionality
|
||||
- Potential lose some compatibility with Helm
|
||||
- Potentially lose some compatibility with Helm
|
||||
|
||||
## Alternatives considered
|
||||
|
||||
- Implement Helm fully
|
||||
- Pros:
|
||||
- Retain full compatibility with Helm as a tool
|
||||
- Retain full functionality of Helm
|
||||
- Cons:
|
||||
- Longer dev time
|
||||
- More complex integration
|
||||
- Dealing with larger (unstable) surface of Helm as a binary
|
||||
- Leverage Kustomize to deal with Helm charts
|
||||
- Pros:
|
||||
-
|
||||
- Cons:
|
||||
-
|
||||
- ### Implement Helm resouce/client fully in Harmony
|
||||
- **Pros**:
|
||||
- Retain full compatibility with Helm as a tool
|
||||
- Retain full functionality of Helm
|
||||
- **Cons**:
|
||||
- Longer dev time
|
||||
- More complex integration
|
||||
- Dealing with larger (unstable) surface of Helm as a binary
|
||||
- ### Leverage Kustomize to deal with Helm charts
|
||||
- **Pros**:
|
||||
- Already has a good, minimal inflation solution built
|
||||
- Powerful post-processing/patching
|
||||
- Can integrate with `kubectl`
|
||||
- **Cons**:
|
||||
- Unstable binary tool/surface to deal with
|
||||
- Still requires Helm to be installed as well as Kustomize
|
||||
- Not all Helm features supported
|
||||
|
||||
## Additional Notes
|
||||
|
||||
Loading…
Reference in New Issue
Block a user