matthieu.evrin/harmony
1
0
Fork 0
forked from NationTech/harmony
Code Pull Requests Activity

feat: don't crash if ip:mac already exist, just skip it

Browse Source
This commit is contained in:
Sylvain Tremblay 2024-12-18 10:46:36 -05:00 committed by johnride
parent f7e97f5c81
commit 0247252474
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
harmony-rs/opnsense-config/src/modules/dhcp.rs
View File

@ -1,3 +1,4 @@
use log::info;
use opnsense_config_xml::MaybeString;
use opnsense_config_xml::Range;
use opnsense_config_xml::StaticMap;
@ -93,6 +94,21 @@ impl<'a> DhcpConfig<'a> {
// return Err(DhcpError::IpAddressOutOfRange(ipaddr.to_string()));
// }
if existing_mappings.iter().any(|m| {
m.ipaddr
.parse::<Ipv4Addr>()
.expect("Mapping contains invalid ipv4")
== ipaddr
&& m.mac == mac
}) {
info!(
"Mapping already exists for {} [{}], skipping",
ipaddr.to_string(),
mac
);
return Ok(());
}
if existing_mappings.iter().any(|m| {
m.ipaddr
.parse::<Ipv4Addr>()