Block a user
feat: Initial setup for monitoring and alerting
A bit of rustdoc would be relevant here to explain the intended use of this trait.
feat: Initial setup for monitoring and alerting
I don't think webhook url deserves to be in this abstract trait. It is possible that the AlertChannel does not have a webhook, such as SMS, phone calls, SMTP.
feat: Initial setup for monitoring and alerting
I feel like this is not a correct abstraction. NotificationAdapter has a responsibility and Deployer has another. This is a strong smell of broken Single Responsibility principle, probably interface segregation too.
feat: Initial setup for monitoring and alerting
I think we can solve the dependency issue by introducing a T here :
feat: Initial setup for monitoring and alerting
Violates OCP : we want to allow external contributors to provide new backend implementations (that is, if we want to introduce the concept of monitoring backend right now or wait until the needs arises?)
TenantManager_impl_k8s_anywhere
feat: Add TenantScore and TenantInterpret
johnride
deleted branch TenantManager_impl_k8s_anywhere from NationTech/harmony
2025-05-29 20:15:53 +00:00
feat: add more to the tenantmanager k8s impl
feat: Add TenantScore and TenantInterpret
e7917843bc
Merge pull request 'feat: Add initial Tenant traits and data structures' (#43) from feat/tenant into master
bf16566b4e
wip: Clean up some unnecessary bits in the Tenant module and move manager to its own file