johnride
  • Joined on 2024-02-06
johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Weird comment here again, does not relate directly to the code block. I think I'd rather not have it.

johnride approved NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

This is just so much better. And it shows in the UX. Usually a good UX requires good code and good code produces a good UX.

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Either I don't understand it or it's an outdated comment, I think those types of comment explaining WHAT the code is doing are generally bad. Comments should explain WHY. If you need to express a WHAT, use a function.

johnride commented on pull request NationTech/harmony#9 2025-04-18 14:57:26 +00:00
feat: harmony-cli v0.1 #8

Those 8 lines should be extracted to a utilty function in the test module such as "init_test_maestro() -> Maestro"

johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-17 17:04:09 +00:00
34b046c7cc wip: Started work on k3d crate
johnride suggested changes for NationTech/harmony#9 2025-04-17 15:24:57 +00:00
feat: harmony-cli v0.1 #8

Few things to fix still :

johnride pushed to tui-score-info at NationTech/harmony 2025-04-17 14:50:49 +00:00
feea9780ab feat: example-lamp now uses harmony-tui
afbbde694a fix: Activate opnsense test only with opnsenseendtoend feature enabled
Compare 2 commits »
johnride commented on pull request NationTech/harmony#11 2025-04-17 14:49:23 +00:00
tui-score-info

image

C'est mieux. mais je pense que ca merite encore un peu d'amour si c'est pas trop difficile pour le rendering d'un Map.

Ca serait…

johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-17 13:56:01 +00:00
e7a5100891 wip: Implement basic K8sAnywhere setup with K3d support
johnride commented on pull request NationTech/harmony#12 2025-04-16 01:27:45 +00:00
docs: ADR for Helm Resource implementation style

I generally feel wrong about not using an existing tool to deploy helm packages. I feel like using kustomize would be more reasonable here but at the same time it's not that hard to develop the…

johnride suggested changes for NationTech/harmony#9 2025-04-14 19:04:48 +00:00
feat: harmony-cli v0.1 #8
  1. cargo run -p example-cli -- -a
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-14 18:57:07 +00:00
b181c67fcf feat: Introduce K8sAnywhereTopology and refactor Kubernetes interactions
johnride suggested changes for NationTech/harmony#9 2025-04-12 12:09:51 +00:00
feat: harmony-cli v0.1 #8
johnride commented on pull request NationTech/harmony#9 2025-04-12 12:09:51 +00:00
feat: harmony-cli v0.1 #8

Je viens de l'essayer, semble pas pire, mais je pense que ca prend quelques trucs pour que le UX soit correct :

johnride created pull request NationTech/harmony#10 2025-04-11 20:22:48 +00:00
feat: introduce topology readiness and initialization
johnride pushed to feat/topologyDependencies at NationTech/harmony 2025-04-11 20:22:00 +00:00
7ed27e2018 feat: introduce topology readiness and initialization
johnride created branch feat/topologyDependencies in NationTech/harmony 2025-04-11 20:22:00 +00:00
johnride commented on pull request NationTech/harmony#9 2025-04-11 19:32:05 +00:00
feat: harmony-cli v0.1 #8

Calling a function here that uses .iter().filter() and returns an option is more idiomatic rust (and more robust) than the mut bool found and mut count Just filter the array and them you can match filtered.len()

johnride suggested changes for NationTech/harmony#9 2025-04-11 19:32:05 +00:00
feat: harmony-cli v0.1 #8

Code is simple, which is good enough for a mini prototype like this.

johnride deleted branch adr/005-interactive-project from NationTech/harmony 2025-04-11 15:06:26 +00:00