johnride
  • Joined on 2024-02-06
johnride pushed to feat/tenant at NationTech/harmony 2025-05-29 02:34:08 +00:00
895fb02f4e feat: Add initial Tenant traits and data structures
johnride created branch feat/tenant in NationTech/harmony 2025-05-29 02:34:07 +00:00
johnride commented on pull request NationTech/harmony#40 2025-05-29 00:11:50 +00:00
feat/teams-integration

Oh it's in the examples, forget this.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

This entire file looks pretty good 👍

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

I think PrometheusAlertChannel is a good name for the trait. However both function names feel off :

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

Yeah I don't think this will work. Show me the actual json that this produces and why you need to use this.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

typetag doesn't seem to be a good idea here. Why do you use it? Show me an actual use case that requires it versus having a trait bound + Serialize on the PrometheusAlertChannel trait.

johnride suggested changes for NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

Much better than previous iteration. But still a lot of room for improvement.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:27 +00:00
feat/teams-integration

Is this really required? This feels wrong, at least it would deserve a small comment explaining why you are ALWAYS instanciating a hardcoded NullReceiver

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:27 +00:00
feat/teams-integration

Why is all this config hardcoded? Shouldn't it be exposed in the Score's configuration? I think it should have defaults so that users are not forced to set everything by themselves but it should not be hardcoded.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:27 +00:00
feat/teams-integration

I am 99% sure this is wrong.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:27 +00:00
feat/teams-integration

This should be behind a feature flag such as "msteams-deprecated"

johnride deleted branch feat/basicCI from NationTech/harmony 2025-05-28 19:42:26 +00:00
johnride pushed to master at NationTech/harmony 2025-05-28 19:42:25 +00:00
88d6af9815 Merge pull request 'feat/basicCI' (#42) from feat/basicCI into master
5aa9dc701f fix: Removed forgotten refactoring bits and formatting
f4ef895d2e feat: Add basic CI configuration
Compare 3 commits »
johnride merged pull request NationTech/harmony#42 2025-05-28 19:42:24 +00:00
feat/basicCI
johnride created pull request NationTech/harmony#42 2025-05-28 19:25:21 +00:00
feat/basicCI
johnride pushed to feat/basicCI at NationTech/harmony 2025-05-28 19:19:48 +00:00
5aa9dc701f fix: Removed forgotten refactoring bits and formatting
johnride pushed to feat/basicCI at NationTech/harmony 2025-05-28 18:40:32 +00:00
f4ef895d2e feat: Add basic CI configuration
johnride created branch feat/basicCI in NationTech/harmony 2025-05-28 18:40:31 +00:00
johnride deleted branch adr/multi-tenancy from NationTech/harmony 2025-05-26 20:26:39 +00:00