3276c08775
feat(inventory-agent): Discover algorithm by scanning a subnet of ips, slower than mdns but more reliable and versatile
4ff57062ae
Merge pull request 'feat(kube): Convert kube_openapi Resource to DynamicObject' (#180) from feat/kube_convert_dynamic_resource into master
50ce54ea66
Merge pull request 'fix(opnsense-config): mark Interface::enable as optional' (#181) from fix-opnsense-config into master
4ff57062ae
Merge pull request 'feat(kube): Convert kube_openapi Resource to DynamicObject' (#180) from feat/kube_convert_dynamic_resource into master
95cfc03518
feat(kube): Utility function to convert kube_openapi Resource to DynamicObject. This will allow initializing resources strongly typed and then bundle various types into a list of DynamicObject
I am merging, we can continue the conversation later.
It does not validate "this" directly, it just validates that the serde Serialize implementation returns equal values for original and dynamic. For all we know they could be empty. I want to make…
I know it looks this way but I feel more comfortable having them in.
We're completely dependent on the serialized values for the "real" assertion above and I've often seen cases where the value…
Looks pretty straightforward 👍
Overall LGTM, a few considerations here and there but nothing major.
url::parse can fail at runtime, would hurl! work here?
Why is this function and logic in ha_cluster instead of network manager?
I guess this is required because the operator from the catalog does not work?
I really don't like the boilerplate added by having multiple error types for each bit of business logic.
Why OnceLock instead of Oncecell or something else? I'm not familiar with it. I guess it takes a read lock when accessed after initialization?
Rust is so beautiful. Type K infered from return type, completely transparent, super powerful, super readable, super intuitive.
LGTM, just make sure the bond checking logic is correct.
Why type Bond AND link_aggregation ?