Block a user
monitoringalerting
Good improvement over the first version, still some work to do to have it really look good. Keep it up!
monitoringalerting
No need for this monitoring_stack: Stack field for now. This is a case of YAGNI. We support only one type and I don't see in the very short term a use case that would force us.
monitoringalerting
What is service_name used for? As this is user facing, a bit of rust doc (with triple slashes ///) to describe how to use would be useful here.
monitoringalerting
Nice, but did you test smtp? If it's not working yet there should be a // TODO comment or something like that.
monitoringalerting
Why use values_overrides here when there already is a values_yaml right above? Would make it a lot more readable I think.
feat: add ingress score
What about path, path_type and namespace? These certainly don't support any String?
861f266c4e
Merge pull request 'feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution' (#36) from feat/lampOKD into master
51724d0e55
feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution
feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution
51724d0e55
feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution
ad72409287
feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution
c2d1cb9b76
Merge pull request 'upgrade stack size from default 1MB on windows (k3d stack overflow otherwise)' (#34) from windows-stack-size-increase into master
feat: LAMP stack and Monitoring stack now work on OKD, we just have to manually set a few serviceaccounts to privileged scc until we find a better solution
johnride
deleted branch upload_folder_improvements from NationTech/harmony
2025-05-14 15:35:04 +00:00