It does not validate "this" directly, it just validates that the serde Serialize implementation returns equal values for original and dynamic. For all we know they could be empty. I want to make…
I know it looks this way but I feel more comfortable having them in.
We're completely dependent on the serialized values for the "real" assertion above and I've often seen cases where the value…
Looks pretty straightforward 👍
I really don't like the boilerplate added by having multiple error types for each bit of business logic.
I guess this is required because the operator from the catalog does not work?
url::parse can fail at runtime, would hurl! work here?
Overall LGTM, a few considerations here and there but nothing major.
Why is this function and logic in ha_cluster instead of network manager?
Why OnceLock instead of Oncecell or something else? I'm not familiar with it. I guess it takes a read lock when accessed after initialization?
Why type Bond AND link_aggregation ?
Rust is so beautiful. Type K infered from return type, completely transparent, super powerful, super readable, super intuitive.
LGTM, just make sure the bond checking logic is correct.