johnride
0 Followers · 0 Following
  • Joined on 2024-02-06
Repositories
3
 Projects Packages Public Activity Starred Repositories
1
johnride commented on pull request NationTech/harmony#43 2025-05-29 15:40:52 +00:00
feat: Add initial Tenant traits and data structures

YAGNI

johnride commented on pull request NationTech/harmony#43 2025-05-29 15:40:52 +00:00
feat: Add initial Tenant traits and data structures

Useless comments

johnride commented on pull request NationTech/harmony#43 2025-05-29 15:40:52 +00:00
feat: Add initial Tenant traits and data structures

Tenant name can change. Our business context for this is typically a client or project name. Clients can change names, be bought, etc.

johnride deleted branch doc/contributor from NationTech/harmony 2025-05-29 14:48:28 +00:00
johnride pushed to master at NationTech/harmony 2025-05-29 14:48:24 +00:00
270dd49567 Merge pull request 'docs: Add CONTRIBUTING.md guide' (#44) from doc/contributor into master
0187300473 docs: Add CONTRIBUTING.md guide
Compare 2 commits »
johnride merged pull request NationTech/harmony#44 2025-05-29 14:48:23 +00:00
docs: Add CONTRIBUTING.md guide
johnride created pull request NationTech/harmony#44 2025-05-29 14:48:11 +00:00
docs: Add CONTRIBUTING.md guide
johnride pushed to doc/contributor at NationTech/harmony 2025-05-29 14:47:53 +00:00
0187300473 docs: Add CONTRIBUTING.md guide
johnride created branch doc/contributor in NationTech/harmony 2025-05-29 14:47:52 +00:00
johnride pushed to feat/tenant at NationTech/harmony 2025-05-29 11:26:03 +00:00
bf16566b4e wip: Clean up some unnecessary bits in the Tenant module and move manager to its own file
johnride pushed to feat/tenant at NationTech/harmony 2025-05-29 11:22:45 +00:00
dc43be99fe wip: Clean up some unnecessary bits in the Tenant module and move manager to its own file
johnride created pull request NationTech/harmony#43 2025-05-29 02:36:44 +00:00
WIP: feat: Add initial Tenant traits and data structures
johnride pushed to feat/tenant at NationTech/harmony 2025-05-29 02:34:08 +00:00
895fb02f4e feat: Add initial Tenant traits and data structures
johnride created branch feat/tenant in NationTech/harmony 2025-05-29 02:34:07 +00:00
johnride commented on pull request NationTech/harmony#40 2025-05-29 00:11:50 +00:00
feat/teams-integration

Oh it's in the examples, forget this.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

I think PrometheusAlertChannel is a good name for the trait. However both function names feel off :

johnride suggested changes for NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

Much better than previous iteration. But still a lot of room for improvement.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

This entire file looks pretty good 👍

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

Yeah I don't think this will work. Show me the actual json that this produces and why you need to use this.

johnride commented on pull request NationTech/harmony#40 2025-05-29 00:04:28 +00:00
feat/teams-integration

typetag doesn't seem to be a good idea here. Why do you use it? Show me an actual use case that requires it versus having a trait bound + Serialize on the PrometheusAlertChannel trait.