johnride

johnride commented on pull request NationTech/harmony#48

2025-06-02 12:54:31 +00:00

feat: Initial setup for monitoring and alerting

I feel like this is not a correct abstraction. NotificationAdapter has a responsibility and Deployer has another. This is a strong smell of broken Single Responsibility principle, probably interface segregation too.

johnride commented on pull request NationTech/harmony#48

2025-06-02 12:54:30 +00:00

feat: Initial setup for monitoring and alerting

Violates OCP : we want to allow external contributors to provide new backend implementations (that is, if we want to introduce the concept of monitoring backend right now or wait until the needs arises?)

johnride created pull request NationTech/harmony#47

2025-05-30 13:15:13 +00:00

TenantManager_impl_k8s_anywhere

johnride deleted branch feat/tenantScore from NationTech/harmony

2025-05-30 13:13:55 +00:00

johnride pushed to master at NationTech/harmony

2025-05-30 13:13:52 +00:00

60f2f31d6c feat: Add TenantScore and TenantInterpret (#45)

johnride merged pull request NationTech/harmony#45

2025-05-30 13:13:50 +00:00

feat: Add TenantScore and TenantInterpret

johnride deleted branch TenantManager_impl_k8s_anywhere from NationTech/harmony

2025-05-29 20:15:53 +00:00

johnride pushed to master at NationTech/harmony

2025-05-29 20:15:48 +00:00

27f1a9dbdd feat: add more to the tenantmanager k8s impl (#46)

johnride merged pull request NationTech/harmony#46

2025-05-29 20:15:44 +00:00

feat: add more to the tenantmanager k8s impl

johnride created pull request NationTech/harmony#45

2025-05-29 17:31:34 +00:00

feat: Add TenantScore and TenantInterpret

johnride pushed to feat/tenantScore at NationTech/harmony

2025-05-29 17:31:17 +00:00

06dbe425c7 feat: Add TenantScore and TenantInterpret

johnride created branch feat/tenantScore in NationTech/harmony

2025-05-29 17:31:17 +00:00

johnride deleted branch feat/tenant from NationTech/harmony

2025-05-29 15:51:45 +00:00

johnride pushed to master at NationTech/harmony

2025-05-29 15:51:41 +00:00

e7917843bc Merge pull request 'feat: Add initial Tenant traits and data structures' (#43) from feat/tenant into master

7cd541bdd8 chore: Fix pr comments, remove many YAGNI things

bf16566b4e wip: Clean up some unnecessary bits in the Tenant module and move manager to its own file

895fb02f4e feat: Add initial Tenant traits and data structures

Compare 4 commits »

johnride merged pull request NationTech/harmony#43

2025-05-29 15:51:37 +00:00

feat: Add initial Tenant traits and data structures

johnride pushed to feat/tenant at NationTech/harmony

2025-05-29 15:47:36 +00:00

7cd541bdd8 chore: Fix pr comments, remove many YAGNI things

johnride commented on pull request NationTech/harmony#43

2025-05-29 15:40:53 +00:00

feat: Add initial Tenant traits and data structures

BAD

johnride commented on pull request NationTech/harmony#43

2025-05-29 15:40:53 +00:00

feat: Add initial Tenant traits and data structures

YAGNI

johnride commented on pull request NationTech/harmony#43

2025-05-29 15:40:52 +00:00

feat: Add initial Tenant traits and data structures

YAGNI

johnride commented on pull request NationTech/harmony#43

2025-05-29 15:40:52 +00:00

feat: Add initial Tenant traits and data structures

Delete from here