johnride
  • Joined on 2024-02-06
johnride pushed to feat/applicationModule at NationTech/harmony 2025-07-01 14:20:11 +00:00
ae95c44867 chore: Refactor application module after code review
johnride created pull request NationTech/harmony#70 2025-06-30 19:43:06 +00:00
feat: Application module architecture and placeholder features
johnride pushed to feat/applicationModule at NationTech/harmony 2025-06-30 19:41:28 +00:00
34abe3af24 feat: Application module architecture and placeholder features
johnride pushed to feat/applicationModule at NationTech/harmony 2025-06-29 02:51:15 +00:00
923de4506e feat: ApplicationModule with tentative architecture and placeholder implementation of first few features
johnride released Latest Snapshot at NationTech/harmony 2025-06-26 16:46:16 +00:00
johnride released Latest Snapshot at NationTech/harmony 2025-06-26 16:42:44 +00:00
johnride pushed to master at NationTech/harmony 2025-06-26 16:41:54 +00:00
fea7e9ddb9 doc: Improve harmony_composer README single command usage
johnride released Latest Snapshot at NationTech/harmony 2025-06-26 15:15:27 +00:00
johnride deleted branch feat/dryRun from NationTech/harmony 2025-06-26 15:14:56 +00:00
johnride pushed to master at NationTech/harmony 2025-06-26 15:14:37 +00:00
55143dcad4 Merge pull request 'feat: add dry-run functionality and similar dependency' (#62) from feat/dryRun into master
acfb93f1a2 feat: add dry-run functionality and similar dependency
Compare 2 commits »
johnride merged pull request NationTech/harmony#62 2025-06-26 15:14:31 +00:00
feat: add dry-run functionality and similar dependency
johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:44 +00:00
feat: add service monitors support to prom

That is inconvenient to use. Should be much shorter with something like :

johnride suggested changes for NationTech/harmony#66 2025-06-26 14:05:44 +00:00
feat: add service monitors support to prom

The good :

johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:43 +00:00
feat: add service monitors support to prom

I guess operator is not any string? Probably should be an enum too.

johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:43 +00:00
feat: add service monitors support to prom

I think we already do have a Label type somewhere. I think it would be more appropriate here than String. That's true for all the label related fields in this file.

johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:42 +00:00
feat: add service monitors support to prom

Not a String, should be a path type of some sort. I think we already handle this somewhere else correctly.

johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:42 +00:00
feat: add service monitors support to prom

This should be an enum :

johnride commented on pull request NationTech/harmony#66 2025-06-26 14:05:42 +00:00
feat: add service monitors support to prom

This should be a specific type that validates the path

johnride commented on pull request NationTech/harmony#66 2025-06-26 13:49:07 +00:00
feat: add service monitors support to prom

Yeah ok, I see what you did there.

But this is not a good use case for Macros. Macros are a last resort when the type semantics are already correct and we can't rely on the regular rust type…

johnride commented on pull request NationTech/harmony#66 2025-06-26 13:30:05 +00:00
feat: add service monitors support to prom

OK that makes sense. Why not implement Display? I guess the format is not the expected one?

Also this file really deserves some tests to make sure the config output is correct.