NationTech/harmony
6
0
Fork 1
Code Issues 35 Pull Requests 6 Actions Packages Projects Releases 1 Wiki Activity

feat: add service monitors support to prom #66

Merged
johnride merged 9 commits from monitoring_servicemonitor into master 2025-07-02 15:29:23 +00:00
Conversation 0 Commits 9 Files Changed 7 +3 -3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cbbe52fe9b - Show all commits

2
examples/monitoring/src/main.rs
View File

@ -46,7 +46,7 @@ async fn main() {
);
let service_monitor_endpoint = ServiceMonitorEndpoint {
port: Some(80),
port: Some("80".to_string()),
target_port: None,
bearer_token_file: None,
interval: None,

4
harmony/src/modules/monitoring/kube_prometheus/types.rs
View File

@ -96,11 +96,11 @@ pub struct ServiceMonitorTLSConfig {
pub struct ServiceMonitorEndpoint {
// ## Name of the endpoint's service port
// ## Mutually exclusive with targetPort
pub port: Option<u16>,
pub port: Option<String>,
// ## Name or number of the endpoint's target port
// ## Mutually exclusive with port
johnride commented 2025-06-26 13:42:04 +00:00
Outdated
Review
Copy Link

This should be a specific type that validates the path

This should be a specific type that validates the path
pub target_port: Option<u16>,
pub target_port: Option<String>,
// ## File containing bearer token to be used when scraping targets
// ##
taha marked this conversation as resolved Outdated
johnride commented 2025-06-26 13:40:14 +00:00
Outdated
Review
Copy Link

This should be an enum :

pub enum URLScheme {
 HTTP,
 HTTPS,
 // Maybe others such as :
 FILE,
 FTP,
 OTHER(String), // With this we are both usable with more frequent schemes and extensible 
}

impl Display for URLScheme {
 // TODO
}
This should be an enum : ```rust pub enum URLScheme { HTTP, HTTPS, // Maybe others such as : FILE, FTP, OTHER(String), // With this we are both usable with more frequent schemes and extensible } impl Display for URLScheme { // TODO }