NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions Packages Projects Releases 1 Wiki Activity

WIP: feat: implementation for opnsense os-node_exporter #173

Draft
wjro wants to merge 3 commits from feat/install_opnsense_node_exporter into master
pull from: feat/install_opnsense_node_exporter
merge into: NationTech:master
Conversation 2 Commits 3 Files Changed 17 +6 -7
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5af13800b7 - Show all commits

13
opnsense-config/src/modules/node_exporter.rs
View File

@ -20,21 +20,20 @@ impl<'a> NodeExporterConfig<'a> {
pub fn get_full_config(&self) -> &Option<NodeExporter> { pub fn get_full_config(&self) -> &Option<NodeExporter> {
&self.opnsense.opnsense.node_exporter &self.opnsense.opnsense.node_exporter
} }
fn with_node_exporter<F, R>(&mut self, f: F) -> R
wjro marked this conversation as resolved Outdated
letian commented 2025-10-22 15:34:42 +00:00
Outdated
Review
Copy Link

white line missing

white line missing
fn with_node_exporter<F, R>(&mut self, f: F) -> Result<R, &'static str>
where where
F: FnOnce(&mut NodeExporter) -> R, F: FnOnce(&mut NodeExporter) -> R,
{ {
match &mut self.opnsense.opnsense.node_exporter.as_mut() { match &mut self.opnsense.opnsense.node_exporter.as_mut() {
Some(node_exporter) => f(node_exporter), Some(node_exporter) => Ok(f(node_exporter)),
None => unimplemented!( None => Err("node exporter is not yet installed"),
wjro marked this conversation as resolved Outdated
letian commented 2025-10-22 15:34:54 +00:00
Outdated
Review
Copy Link

is it expected to have a line return here?

is it expected to have a line return here?
"
node exporter is not yet installed"
),
} }
} }
pub fn enable(&mut self, enabled: bool) { pub fn enable(&mut self, enabled: bool) -> Result<(), &'static str> {
self.with_node_exporter(|node_exporter| node_exporter.enabled = enabled as u8) self.with_node_exporter(|node_exporter| node_exporter.enabled = enabled as u8)
.map(|_| ())
} }
pub async fn reload_restart(&self) -> Result<(), Error> { pub async fn reload_restart(&self) -> Result<(), Error> {