NationTech/harmony
6
0
Fork 1
Code Issues 35 Pull Requests 7 Actions Packages Projects Releases 1 Wiki Activity

working on ensure_ready to check helm is available #17

Merged
taha merged 2 commits from ensure-helm-available into master 2025-04-24 15:51:29 +00:00
Conversation 0 Commits 2 Files Changed 1 +13 -9
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7576c4a74c - Show all commits

20
harmony/src/domain/topology/k8s_anywhere.rs
View File

@ -38,7 +38,7 @@ impl K8sAnywhereTopology {
fn is_helm_available(&self) -> Result<(), String> { fn is_helm_available(&self) -> Result<(), String> {
let version_result = Command::new("helm") let version_result = Command::new("helm")
.arg("-version") .arg("version")
taha commented 2025-04-24 15:20:34 +00:00
Outdated
Review
Copy Link

Helm doesn't have -version it would be version or something like .args(vec!["version", "-c", "--short"]) for a shorter output

Helm doesn't have `-version` it would be `version` or something like `.args(vec!["version", "-c", "--short"])` for a shorter output
.output() .output()
.map_err(|e| format!("Failed to execute 'helm -version': {}", e))?; .map_err(|e| format!("Failed to execute 'helm -version': {}", e))?;
@ -155,16 +155,20 @@ impl Topology for K8sAnywhereTopology {
.k8s_state .k8s_state
.get_or_try_init(|| self.try_get_or_install_k8s_client()) .get_or_try_init(|| self.try_get_or_install_k8s_client())
.await?; .await?;
//{
// Some(k8s_state) => Ok(Outcome::success(k8s_state.message.clone())), let k8s_state: &K8sState = k8s_state
// None => Err(InterpretError::new("No K8s client could be found or installed".to_string(), .as_ref()
// )), .ok_or(InterpretError::new(
//} "No K8s client could be found or installed".to_string(),
))?;
match self.is_helm_available() { match self.is_helm_available() {
Ok(()) => Ok(Outcome::success("helm available".to_string())), Ok(()) => Ok(Outcome::success(format!(
"{} + helm available",
k8s_state.message.clone()
))),
Err(_) => Err(InterpretError::new("helm unavailable".to_string())), Err(_) => Err(InterpretError::new("helm unavailable".to_string())),
} }
} }
} }