NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

Create harmony_composer initial #58

Merged
taha merged 52 commits from harmony_ci_cli into master 2025-06-18 19:52:43 +00:00
Conversation 1 Commits 52 Files Changed 8 +723 -9
taha commented 2025-06-10 20:28:17 +00:00
Collaborator
Copy Link
No description provided.
johnride commented 2025-06-11 18:55:17 +00:00
Owner
Copy Link

I'm thinking so many things that I'm not sure what to think 😆

One one hand, there are many interesting ideas there and I'm really curious to see how it will evolve.

On the other hand, I feel like it would be better to start smaller and simpler, with one very clear feature to implement for our customer. Implement one full simple feature instead of planning all the future features before even having one done. Working too wide and not following YAGNI enough is usually how you end up with an architecture that does not work/scales well because we haven't figured out yet how it actually works.

So I guess that at this point we can keep it like this as a starting point, but now we should focus on end-to-end integration of the first feature. I guess that would be creating a simple way to use this CLI to detect an existing harmony configuration and execute it without providing more advanced functionnality at this point, just basic execution of whatever is already written in the harmony code.

I'm thinking so many things that I'm not sure what to think 😆 One one hand, there are many interesting ideas there and I'm really curious to see how it will evolve. On the other hand, I feel like it would be better to start smaller and simpler, with one very clear feature to implement for our customer. Implement one full simple feature instead of planning all the future features before even having one done. Working too wide and not following YAGNI enough is usually how you end up with an architecture that does not work/scales well because we haven't figured out yet how it actually works. So I guess that at this point we can keep it like this as a starting point, but now we should focus on end-to-end integration of the first feature. I guess that would be creating a simple way to use this CLI to detect an existing harmony configuration and execute it without providing more advanced functionnality at this point, just basic execution of whatever is already written in the harmony code.
johnride approved these changes 2025-06-11 18:55:29 +00:00
Dismissed
Cargo.toml Outdated
@ -11,3 +11,3 @@
"opnsense-config-xml",
"harmony_cli",
"k3d",
"k3d", "harmony_composer",
johnride commented 2025-06-11 18:34:03 +00:00
Owner
Copy Link

Format

Format
taha marked this conversation as resolved
taha force-pushed harmony_ci_cli from d05375f5ee to 9c29e92a46 2025-06-16 14:45:36 +00:00 Compare
taha force-pushed harmony_ci_cli from 0da10a1ee2 to 3f69edf059 2025-06-17 19:47:16 +00:00 Compare
taha added 1 commit 2025-06-17 19:53:31 +00:00
try without setting up buildx
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1m3s
Details
d285ae988c
taha added 1 commit 2025-06-17 19:58:46 +00:00
add buildx step back, github having problems?
Some checks failed
Run Check Script / check (push) Successful in 1m49s
Details
Run Check Script / check (pull_request) Successful in 1m52s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1m9s
Details
42c17345cf
taha added 1 commit 2025-06-17 20:43:33 +00:00
try with podman?
Some checks failed
Run Check Script / check (push) Successful in 1m49s
Details
Run Check Script / check (pull_request) Successful in 1m49s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1m29s
Details
a4d8609b29
taha added 1 commit 2025-06-17 21:01:15 +00:00
try with --privileged
Some checks failed
Run Check Script / check (push) Successful in 1m50s
Details
Run Check Script / check (pull_request) Successful in 1m50s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1m9s
Details
275a470d00
taha added 1 commit 2025-06-18 13:53:55 +00:00
switch back to docker
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Successful in 1m52s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1m12s
Details
be0fbf08fb
taha added 1 commit 2025-06-18 13:55:33 +00:00
update SHA
Some checks failed
Run Check Script / check (push) Waiting to run
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 1s
Details
Run Check Script / check (pull_request) Has been cancelled
Details
49fc459674
taha added 1 commit 2025-06-18 13:56:16 +00:00
wrong SHA
Some checks failed
Run Check Script / check (push) Waiting to run
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
a7ed31d4f1
taha added 1 commit 2025-06-18 13:58:30 +00:00
run only on taha docker runner for debugging
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 1m43s
Details
1cb010342e
taha added 1 commit 2025-06-18 14:14:12 +00:00
It worked with --privileged with rootful docker, try podman with rootless
All checks were successful
Run Check Script / check (push) Successful in 1m51s
Details
Run Check Script / check (pull_request) Successful in 1m51s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 40s
Details
1bfd7a2dd5
taha added 1 commit 2025-06-18 14:59:26 +00:00
update docker sha
Some checks failed
Run Check Script / check (push) Successful in 1m51s
Details
Run Check Script / check (pull_request) Successful in 1m50s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 6s
Details
e49a0c6680
taha added 2 commits 2025-06-18 15:02:00 +00:00
update sha
All checks were successful
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 40s
Details
Run Check Script / check (push) Successful in 1m50s
Details
Run Check Script / check (pull_request) Successful in 1m51s
Details
585595239f
taha added 1 commit 2025-06-18 15:11:00 +00:00
update sha again
Some checks failed
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 38s
Details
Run Check Script / check (push) Successful in 1m53s
Details
Run Check Script / check (pull_request) Has been cancelled
Details
1e50124dd5
taha added 1 commit 2025-06-18 15:13:29 +00:00
switch back to docker tag runs-on
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 37s
Details
2ef5ab8b29
taha added 1 commit 2025-06-18 15:17:43 +00:00
try with rootless docker sock?
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 6s
Details
6ccbd3791c
taha added 1 commit 2025-06-18 15:19:28 +00:00
hardcode user 1001
Some checks failed
Run Check Script / check (push) Has been cancelled
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 6s
Details
818e6086c5
taha added 1 commit 2025-06-18 15:22:41 +00:00
try mounting user docker.sock into container
Some checks failed
Run Check Script / check (push) Successful in 1m51s
Details
Run Check Script / check (pull_request) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 8s
Details
ed07601772
taha added 1 commit 2025-06-18 15:26:55 +00:00
use proper volume option
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
Run Check Script / check (push) Has been cancelled
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 3m15s
Details
9f0082b1e8
taha added 1 commit 2025-06-18 19:16:27 +00:00
Switch to running on dind (Docker-in-Docker supporting) runners
All checks were successful
Run Check Script / check (push) Successful in 1m51s
Details
Run Check Script / check (pull_request) Successful in 1m51s
Details
Compile and package harmony_composer / package_harmony_composer (pull_request) Successful in 13m46s
Details
3b30c9281e
taha added 1 commit 2025-06-18 19:19:18 +00:00
no longer runs on PRs, only on merge to master
All checks were successful
Run Check Script / check (push) Successful in 1m52s
Details
Run Check Script / check (pull_request) Successful in 1m56s
Details
66a300f1e4
taha added 1 commit 2025-06-18 19:23:32 +00:00
Forget using the buildx step, it's not needed
Some checks failed
Compile and package harmony_composer / package_harmony_composer (pull_request) Failing after 47s
Details
Run Check Script / check (push) Successful in 1m52s
Details
Run Check Script / check (pull_request) Successful in 1m52s
Details
7c0fc38941
taha added 1 commit 2025-06-18 19:26:52 +00:00
buildx is needed, actually
All checks were successful
Run Check Script / check (push) Successful in 1m52s
Details
Run Check Script / check (pull_request) Successful in 1m51s
Details
0fcc4a5734
taha added 1 commit 2025-06-18 19:34:16 +00:00
don't run check script twice
All checks were successful
Run Check Script / check (pull_request) Successful in 1m50s
Details
0a42fa62ff
taha added 1 commit 2025-06-18 19:36:15 +00:00
run check.sh in docker
Some checks failed
Run Check Script / check (pull_request) Failing after -54s
Details
46985b561a
taha added 1 commit 2025-06-18 19:37:25 +00:00
run in our docker image
Some checks failed
Run Check Script / check (pull_request) Failing after -33s
Details
d8f50b2834
taha added 1 commit 2025-06-18 19:43:39 +00:00
update dockerfile with rustfmt
All checks were successful
Run Check Script / check (pull_request) Successful in 2m7s
Details
f4a12ccbe3
johnride approved these changes 2025-06-18 19:51:42 +00:00
taha merged commit 155e9bac28 into master 2025-06-18 19:52:43 +00:00
taha deleted branch harmony_ci_cli 2025-06-18 19:52:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
johnride
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#58
No description provided.
Delete Branch "harmony_ci_cli"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?