NationTech/harmony
3
0
Fork 2
Code Issues 38 Pull Requests 29 Actions Packages Projects Releases 1 Wiki Activity

refactor(fleet-operator): replace ScorePayload with ReconcileScore in Deployment CRD [NationTech/Team#186] #278

Merged
johnride merged 1 commits from fix/refactorScorePayload into feat/iot-walking-skeleton 2026-05-05 14:04:44 +00:00
Conversation 0 Commits 1 Files Changed 7 +28 -98
stremblay commented 2026-04-28 12:02:08 +00:00
Owner
Copy Link

Removes the hand-typed ScorePayload struct and its custom schemars
schema function. DeploymentSpec.score is now typed as the strongly
typed ReconcileScore enum already used by the agent, eliminating
duplication and ensuring the CRD schema is derived automatically.

  • Add JsonSchema derive to PodmanService, PodmanV0Score, ReconcileScore
  • Enable podman feature on harmony dependency in operator
  • Re-export ReconcileScore/PodmanV0Score/PodmanService from crd module
  • Update harmony_apply_deployment and fleet_load_test examples
  • Remove TODO comment from harmony_apply_deployment

Wire format is unchanged (externally tagged {type, data}), so the
operator -> NATS KV -> agent path remains fully backward compatible.

Removes the hand-typed ScorePayload struct and its custom schemars schema function. DeploymentSpec.score is now typed as the strongly typed ReconcileScore enum already used by the agent, eliminating duplication and ensuring the CRD schema is derived automatically. - Add JsonSchema derive to PodmanService, PodmanV0Score, ReconcileScore - Enable podman feature on harmony dependency in operator - Re-export ReconcileScore/PodmanV0Score/PodmanService from crd module - Update harmony_apply_deployment and fleet_load_test examples - Remove TODO comment from harmony_apply_deployment Wire format is unchanged (externally tagged {type, data}), so the operator -> NATS KV -> agent path remains fully backward compatible.
stremblay added 1 commit 2026-04-28 12:02:08 +00:00
refactor(fleet-operator): replace ScorePayload with ReconcileScore in Deployment CRD
Some checks failed
Run Check Script / check (pull_request) Failing after 47s
Details
4c78919998 
Removes the hand-typed ScorePayload struct and its custom schemars
schema function. DeploymentSpec.score is now typed as the strongly
typed ReconcileScore enum already used by the agent, eliminating
duplication and ensuring the CRD schema is derived automatically.

- Add JsonSchema derive to PodmanService, PodmanV0Score, ReconcileScore
- Enable podman feature on harmony dependency in operator
- Re-export ReconcileScore/PodmanV0Score/PodmanService from crd module
- Update harmony_apply_deployment and fleet_load_test examples
- Remove TODO comment from harmony_apply_deployment

Wire format is unchanged (externally tagged {type, data}), so the
operator -> NATS KV -> agent path remains fully backward compatible.
stremblay changed title from refactor(fleet-operator): replace ScorePayload with ReconcileScore in Deployment CRD [#186] to refactor(fleet-operator): replace ScorePayload with ReconcileScore in Deployment CRD [NationTech/Team#186] 2026-04-28 12:03:53 +00:00
johnride force-pushed fix/refactorScorePayload from 4c78919998 to 95ccc974f9 2026-05-05 13:59:48 +00:00 Compare
johnride merged commit 92e86fb832 into feat/iot-walking-skeleton 2026-05-05 14:04:44 +00:00
johnride deleted branch fix/refactorScorePayload 2026-05-05 14:04:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel reda stremblay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#278
No description provided.
Delete Branch "fix/refactorScorePayload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?