fix(host_network): retrieve proper hostname and next available bond id #182

letian · 2025-11-04T22:57:56Z

letian commented

2025-11-04 22:57:56 +00:00

In order to query the current network state NodeNetworkState and to apply a NodeNetworkConfigurationPolicy for a given node, we first needed to find its hostname. As all we had was the UUID of a node.

We had different options available (e.g. updating the Harmony Inventory Agent to retrieve it, store it in the OKD installation pipeline on assignation, etc.). But for the sake of simplicity and for better flexibility (e.g. being able to run this score on a cluster that wasn't setup with Harmony), the hostname was retrieved directly in the cluster by running the equivalent of kubectl get nodes -o yaml and matching the nodes with the system UUID.

Other changes

Find the next available bond id for a node
Apply a network config policy for a node (configuring a bond in our case)
Adjust the CRDs for NMState

Note: to see a quick demo, watch the recording in https://git.nationtech.io/NationTech/harmony/pulls/183

In order to query the current network state `NodeNetworkState` and to apply a `NodeNetworkConfigurationPolicy` for a given node, we first needed to find its hostname. As all we had was the UUID of a node. We had different options available (e.g. updating the Harmony Inventory Agent to retrieve it, store it in the OKD installation pipeline on assignation, etc.). But for the sake of simplicity and for better flexibility (e.g. being able to run this score on a cluster that wasn't setup with Harmony), the `hostname` was retrieved directly in the cluster by running the equivalent of `kubectl get nodes -o yaml` and matching the nodes with the system UUID. ### Other changes * Find the next available bond id for a node * Apply a network config policy for a node (configuring a bond in our case) * Adjust the CRDs for NMState Note: to see a quick demo, watch the recording in https://git.nationtech.io/NationTech/harmony/pulls/183

letian added 4 commits 2025-11-04 22:57:57 +00:00

fix(host_network): retrieve proper hostname and next available bond id adc14c052d

find lowest available bond id 4f7b0541f4

better debug log b5beda8efe

uncomment

Run Check Script / check (pull_request) Failing after 1m3s

Details

cab4eb19ed

letian added 1 commit 2025-11-05 17:13:55 +00:00

Merge branch 'master' into network-manager

Run Check Script / check (pull_request) Successful in 1m18s

Details

ca026e1d9e

johnride approved these changes 2025-11-05 20:48:28 +00:00

johnride left a comment

LGTM, just make sure the bond checking logic is correct.

harmony/src/domain/topology/ha_cluster.rs Outdated

						
				@ -271,0 +329,4 @@

				            .and_then(|network_state| network_state.status.current_state.as_ref())

				            .map_or(&interfaces, |current_state| &current_state.interfaces)

				            .iter()

				            .filter(|i| i.r#type == nmstate::InterfaceType::Bond && i.link_aggregation.is_some())

johnride commented

2025-11-05 20:43:02 +00:00

Why type Bond AND link_aggregation ?

I would have thought type bond is enough here? The AND could cause us using an existing bond that has no aggregation (yet)?

Why `type Bond AND link_aggregation` ? I would have thought type bond is enough here? The AND could cause us using an existing bond that has no aggregation (yet)?

letian commented

2025-11-05 23:32:42 +00:00

good point, I'll remove the second part of the check

letian marked this conversation as resolved

harmony/src/domain/topology/k8s.rs

						
				@ -568,0 +614,4 @@

				        &self,

				        list_params: Option<ListParams>,

				    ) -> Result<ObjectList<Node>, Error> {

				        self.list_resources(None, list_params).await