NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

working on ensure_ready to check helm is available #17

Merged
taha merged 2 commits from ensure-helm-available into master 2025-04-24 15:51:29 +00:00
Conversation 2 Commits 2 Files Changed 1 +42 -7
wjro commented 2025-04-24 15:11:44 +00:00
Owner
Copy Link

I want to make sure the changes I'm working on in the ensure_ready don't break anything

I want to make sure the changes I'm working on in the ensure_ready don't break anything
wjro added 1 commit 2025-04-24 15:11:44 +00:00
wip: working on ensure_ready to check helm is available c00eadca5d
taha reviewed 2025-04-24 15:20:34 +00:00
harmony/src/domain/topology/k8s_anywhere.rs Outdated
@@ -31,0 +38,4 @@
fn is_helm_available(&self) -> Result<(), String> {
let version_result = Command::new("helm")
.arg("-version")
taha commented 2025-04-24 15:20:34 +00:00
Collaborator
Copy Link

Helm doesn't have -version it would be version or something like .args(vec!["version", "-c", "--short"]) for a shorter output

Helm doesn't have `-version` it would be `version` or something like `.args(vec!["version", "-c", "--short"])` for a shorter output
wjro added 1 commit 2025-04-24 15:46:31 +00:00
fix: made -version version, used ok_or to return error if k8s_state is not ready 7576c4a74c
taha approved these changes 2025-04-24 15:49:07 +00:00
wjro changed title from wip: working on ensure_ready to check helm is available to working on ensure_ready to check helm is available 2025-04-24 15:50:26 +00:00
taha merged commit 6c06a4ae07 into master 2025-04-24 15:51:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
taha
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#17
No description provided.
Delete Branch "ensure-helm-available"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?