NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

okd_enable_user_workload_monitoring #160

Closed
wjro wants to merge 4 commits from okd_enable_user_workload_monitoring into master
pull from: okd_enable_user_workload_monitoring
merge into: NationTech:master
Conversation 0 Commits 4 Files Changed -
wjro commented 2025-09-19 19:12:51 +00:00
Owner
Copy Link
No description provided.
wjro added 2 commits 2025-09-19 19:12:52 +00:00
letian reviewed 2025-09-26 14:08:33 +00:00
harmony/src/modules/monitoring/okd/enable_user_workload.rs Outdated
@ -0,0 +131,4 @@
.await
}
async fn wait_for_pod_ready(
letian commented 2025-09-26 14:08:33 +00:00
Owner
Copy Link

could it be interesting to move such function into the k8s_client so that others could use it easily? something like k8s_client.wait_for_pod(pod_name: &str, namespace: Option<&str>, status: PodStatus)

could it be interesting to move such function into the `k8s_client` so that others could use it easily? something like `k8s_client.wait_for_pod(pod_name: &str, namespace: Option<&str>, status: PodStatus)`
letian reviewed 2025-09-26 14:14:07 +00:00
harmony/src/modules/monitoring/okd/enable_user_workload.rs
@ -0,0 +90,4 @@
Ok(Outcome::success(
"updated cluster-monitoring-config-map".to_string(),
))
}
letian commented 2025-09-26 14:14:07 +00:00
Owner
Copy Link

for better readability, please add a white line between function declarations to give a bit of space

on a side note, we should always make sure to check for unused imports and also to run cargo fmt and cargo clippy --fix before opening a PR to automatically fix some issues/warnings, the list of warnings (not related to this PR) is growing very quickly

for better readability, please add a white line between function declarations to give a bit of space on a side note, we should always make sure to check for unused imports and also to run `cargo fmt` and `cargo clippy --fix` before opening a PR to automatically fix some issues/warnings, the list of warnings (not related to this PR) is growing very quickly
letian marked this conversation as resolved
letian added 1 commit 2025-10-21 13:48:35 +00:00
Merge branch 'master' into okd_enable_user_workload_monitoring
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details
05f4769ffe
letian closed this pull request 2025-10-21 13:48:49 +00:00
Some checks failed
Run Check Script / check (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#160
No description provided.
Delete Branch "okd_enable_user_workload_monitoring"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?