NationTech/harmony
6
0
Fork 1
Code Issues 32 Pull Requests 7 Actions 7 Packages Projects Releases 1 Wiki Activity

added a monitoring stack that works with openshift/okd. Okd needs to use the cluster observability operator in order to deploy namespaced prometheuses and alertmanagers #134

Merged
letian merged 5 commits from feat/monitoring_cluster_observability into master 2025-09-08 14:22:06 +00:00
Conversation 0 Commits 5 Files Changed 24 +1695 -7
wjro commented 2025-09-05 18:39:39 +00:00
Owner
Copy Link

WIP: Added monitoring stack that works in okd to allow namespaced deployments of alertmanager and prometheuses as well as its associated rules, etc

WIP: Added monitoring stack that works in okd to allow namespaced deployments of alertmanager and prometheuses as well as its associated rules, etc
wjro added 1 commit 2025-09-05 18:39:40 +00:00
wjro added 1 commit 2025-09-05 19:26:30 +00:00
feat: install monitoring stack using rhobs cluster observability operator
All checks were successful
Run Check Script / check (pull_request) Successful in 1m0s
Details
24401b95a9
wjro changed title from wip: added a monitoring stack that works with openshift/okd. Okd needs to use the cluster observability operator in order to deploy namespaced prometheuses and alertmanagers to added a monitoring stack that works with openshift/okd. Okd needs to use the cluster observability operator in order to deploy namespaced prometheuses and alertmanagers 2025-09-05 19:26:43 +00:00
letian reviewed 2025-09-05 19:40:30 +00:00
examples/rhob_application_monitoring/src/main.rs
@ -0,0 +31,4 @@
let app = ApplicationScore {
features: vec![
Box::new(RHOBMonitoring {
letian commented 2025-09-05 19:40:30 +00:00
Owner
Copy Link

Do we really want to keep different monitoring strategies? Instead of just providing one (opinionated) Monitoring feature?

Especially when some part of it is copy-paste from the previous monitoring strategy.

Do we really want to keep different monitoring strategies? Instead of just providing one (opinionated) `Monitoring` feature? Especially when some part of it is copy-paste from the previous monitoring strategy.
letian reviewed 2025-09-05 19:58:06 +00:00
harmony/src/modules/monitoring/kube_prometheus/crd/rhob_cluster_observability_operator.rs
@ -0,0 +7,4 @@
pub fn rhob_cluster_observability_operator() -> HelmChartScore {
HelmChartScore {
namespace: None,
release_name: NonBlankString::from_str("").unwrap(),
letian commented 2025-09-05 19:58:06 +00:00
Owner
Copy Link

shouldn't it have a release name?

shouldn't it have a release name?
letian marked this conversation as resolved
letian reviewed 2025-09-05 19:59:23 +00:00
harmony/src/modules/prometheus/rhob_alerting_score.rs
@ -0,0 +198,4 @@
// if self.crd_exists("grafanas.grafana.integreatly.org").await {
// debug!("grafana CRDs already exist — skipping install.");
// return Ok(Outcome::success("Grafana CRDs already exist".to_string()));
// }
letian commented 2025-09-05 19:59:23 +00:00
Owner
Copy Link

considering we run the update below, I don't think we need to keep this

considering we run the update below, I don't think we need to keep this
letian marked this conversation as resolved
letian reviewed 2025-09-05 20:02:21 +00:00
letian left a comment
Owner
Copy Link

I scanned very briefly the CRDs, so I trust you on this ;)

For the rest, I don't really have comments on what was coded here because most of my comments would be about bigger design issues that we already know about (and that are just carried on here, not your fault). And also hardcoded stuff here and there that we will soon fix in one go (e.g. services URLs).

I scanned very briefly the CRDs, so I trust you on this ;) For the rest, I don't really have comments on what was coded here because most of my comments would be about bigger design issues that we already know about (and that are just carried on here, not your fault). And also hardcoded stuff here and there that we will soon fix in one go (e.g. services URLs).
letian added 1 commit 2025-09-08 14:05:05 +00:00
Merge branch 'master' into feat/monitoring_cluster_observability
Some checks failed
Run Check Script / check (pull_request) Failing after 20s
Details
0148d7890d
letian added 1 commit 2025-09-08 14:11:36 +00:00
add missing service port for rust webapp
All checks were successful
Run Check Script / check (pull_request) Successful in 1m0s
Details
0effb3ca2f
letian added 1 commit 2025-09-08 14:17:11 +00:00
remove leftover comments
All checks were successful
Run Check Script / check (pull_request) Successful in 1m2s
Details
04e800e176
letian merged commit b42815f79c into master 2025-09-08 14:22:06 +00:00
letian deleted branch feat/monitoring_cluster_observability 2025-09-08 14:22:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#134
No description provided.
Delete Branch "feat/monitoring_cluster_observability"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?