NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 16 Actions Packages Projects Releases 1 Wiki Activity

feat/ceph-osd-score #116

Merged
wjro merged 4 commits from feat/ceph-osd-score into master 2025-08-20 18:19:48 +00:00
Conversation 1 Commits 4 Files Changed 5 +547 -1
wjro commented 2025-08-20 16:55:33 +00:00
Owner
Copy Link
No description provided.
wjro added 4 commits 2025-08-20 16:55:38 +00:00
feat: score for preparing rook ceph cluster to remove drive based on rook-ceph-osd deployment name added functions to K8sclient to be able to scale deployment to a desired replicaset number and get pod based on name and namespace b43ca7c740
fix: checks deployment status ready replicas rather than pod name since the pod name is not necessarily matching the deployment name and often has a random generated number in it d1a274b705
feat: socre to remove an osd from the ceph osd tree using K8sClient to interact with rook-ceph-toolbox pod 89eb88d10e
fix: added check to ensure that rook-ceph-tools is available in the designated namespace
All checks were successful
Run Check Script / check (pull_request) Successful in 1m16s
Details
cd3ea6fc10
johnride approved these changes 2025-08-20 18:16:06 +00:00
johnride left a comment
Owner
Copy Link

LGTM 👍

LGTM 👍
harmony/src/modules/storage/ceph/ceph_osd_replacement_score.rs
@@ -0,0 +49,4 @@
topology: &T,
) -> Result<Outcome, InterpretError> {
let client = topology.k8s_client().await.unwrap();
self.verify_ceph_toolbox_exists(client.clone()).await?;
johnride commented 2025-08-20 17:19:56 +00:00
Owner
Copy Link

Nice, super lisible.

Eventuellement plusieurs de ces helper functions pourront aller dans un module ceph management ou quelque chose comme ca.

Nice, super lisible. Eventuellement plusieurs de ces helper functions pourront aller dans un module ceph management ou quelque chose comme ca.
harmony/src/modules/storage/ceph/ceph_osd_replacement_score.rs
@@ -0,0 +123,4 @@
&toolbox_dep, ready_count
)));
} else {
return Err(InterpretError::new(
johnride commented 2025-08-20 17:18:51 +00:00
Owner
Copy Link

Tres cool d'avoir ce check. Eventuellement on pourra etre plus intelligent et proposer au user de demarrer la toolbox mais c'est hors sujet pour l'instant 👍

Tres cool d'avoir ce check. Eventuellement on pourra etre plus intelligent et proposer au user de demarrer la toolbox mais c'est hors sujet pour l'instant 👍
wjro merged commit bfca9cf163 into master 2025-08-20 18:19:48 +00:00
wjro deleted branch feat/ceph-osd-score 2025-08-20 18:19:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
johnride
Labels
Clear labels
Architecture Decision Record
Good first issue
RFC
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
johnride jvtrudel letian stremblay wjro
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NationTech/harmony#116
No description provided.
Delete Branch "feat/ceph-osd-score"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?