NationTech/harmony
5
0
Fork 2
Code Issues 37 Pull Requests 15 Actions Packages Projects Releases 1 Wiki Activity

tui-score-info #11

Merged
johnride merged 10 commits from tui-score-info into master 2025-04-23 14:54:33 +00:00
Conversation 1 Commits 10 Files Changed 10 +281 -25
wjro commented 2025-04-14 14:29:40 +00:00
Owner
Copy Link

WIP: formatted score debug print into a table with a name header and the score information below

WIP: formatted score debug print into a table with a name header and the score information below
wjro force-pushed tui-score-info from 36e7722d49 to 08dbfd827b 2025-04-17 13:45:26 +00:00 Compare
johnride commented 2025-04-17 14:49:23 +00:00
Owner
Copy Link

image

C'est mieux. mais je pense que ca merite encore un peu d'amour si c'est pas trop difficile pour le rendering d'un Map.

J'ai integre le tui dans example-lamp : cargo run -p example-lamp

Ca serait beaucoup plus lisible si c'etait

|config                            | project_root: "./php", ssl_enabled: true |

Je ne sais pas si c'est assez facile a faire.

Aussi, il faudrait enlever l'output en debug juste avant, ou le mettre sur une seule ligne avec {:?} au lieu de {:#?} . Si on ne le met pas c'est plus clean, si on le met ca permet d'avoir vraiment toute l'info brute au besoin.

![image](/attachments/c0f292cd-5260-40cf-a4ad-6848ab8437fd) C'est mieux. mais je pense que ca merite encore un peu d'amour si c'est pas trop difficile pour le rendering d'un Map. J'ai integre le tui dans example-lamp : `cargo run -p example-lamp` Ca serait beaucoup plus lisible si c'etait ``` |config | project_root: "./php", ssl_enabled: true | ``` Je ne sais pas si c'est assez facile a faire. Aussi, il faudrait enlever l'output en debug juste avant, ou le mettre sur une seule ligne avec `{:?}` au lieu de `{:#?}` . Si on ne le met pas c'est plus clean, si on le met ca permet d'avoir vraiment toute l'info brute au besoin.
image.png
207 KiB
johnride added 2 commits 2025-04-17 14:50:50 +00:00
wjro added 1 commit 2025-04-17 19:12:10 +00:00
johnride added 1 commit 2025-04-23 14:33:48 +00:00
johnride added 1 commit 2025-04-23 14:38:03 +00:00
johnride approved these changes 2025-04-23 14:52:46 +00:00
harmony/src/domain/score.rs
@ -42,0 +78,4 @@
for (k, v) in map {
let key_str = match k {
Value::String(s) => s.clone(),
other => format!("{:?}", other),
johnride commented 2025-04-23 14:44:19 +00:00
Owner
Copy Link

Better understand the use case here, or replace the debug with "UNSUPPORTED KEY TYPE"

Better understand the use case here, or replace the debug with "UNSUPPORTED KEY TYPE"
harmony/src/domain/score.rs
@ -42,0 +95,4 @@
}
}
// let first_line = lines.next().unwrap_or("");
johnride commented 2025-04-23 14:41:17 +00:00
Owner
Copy Link

delete

delete
harmony_tui/src/lib.rs
@ -38,3 +38,3 @@
/// };
///
///
/// #[tokio::main]
johnride commented 2025-04-23 14:51:14 +00:00
Owner
Copy Link

delete

delete
johnride merged commit eeafa086f3 into master 2025-04-23 14:54:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
johnride
Labels
Clear labels   
Architecture Decision Record

   
Good first issue

   
RFC
No Label
Architecture Decision Record
Good first issue
RFC
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: NationTech/harmony#11
No description provided.
Delete Branch "tui-score-info"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?