From cb66b7592ec52ae14f95284669e4aaa159a8dabd Mon Sep 17 00:00:00 2001
From: Willem <wrolleman@nationtech.io>
Date: Mon, 20 Oct 2025 14:44:37 -0400
Subject: [PATCH] fix: made targets plural and changed scrape targets to option
 in AlertingInterpret

---
 .../src/domain/topology/oberservability/monitoring.rs  | 10 ++++++----
 .../kube_prometheus/helm_prometheus_alert_score.rs     |  2 +-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/harmony/src/domain/topology/oberservability/monitoring.rs b/harmony/src/domain/topology/oberservability/monitoring.rs
index d9fe4d0..8a1368f 100644
--- a/harmony/src/domain/topology/oberservability/monitoring.rs
+++ b/harmony/src/domain/topology/oberservability/monitoring.rs
@@ -21,7 +21,7 @@ pub struct AlertingInterpret<S: AlertSender> {
     pub sender: S,
     pub receivers: Vec<Box<dyn AlertReceiver<S>>>,
     pub rules: Vec<Box<dyn AlertRule<S>>>,
-    pub scrape_target: Vec<Box<dyn ScrapeTarget<S>>>,
+    pub scrape_targets: Option<Vec<Box<dyn ScrapeTarget<S>>>>,
 }
 
 #[async_trait]
@@ -39,9 +39,11 @@ impl<S: AlertSender + Installable<T>, T: Topology> Interpret<T> for AlertingInte
             debug!("installing rule: {:#?}", rule);
             rule.install(&self.sender).await?;
         }
-        for target in self.scrape_target.iter() {
-            debug!("installing scrape_target: {:#?}", target);
-            target.install(&self.sender).await?;
+        if let Some(targets) = &self.scrape_targets {
+            for target in targets.iter() {
+                debug!("installing scrape_target: {:#?}", target);
+                target.install(&self.sender).await?;
+            }
         }
         self.sender.ensure_installed(inventory, topology).await?;
         Ok(Outcome::success(format!(
diff --git a/harmony/src/modules/monitoring/kube_prometheus/helm_prometheus_alert_score.rs b/harmony/src/modules/monitoring/kube_prometheus/helm_prometheus_alert_score.rs
index da26b03..468d308 100644
--- a/harmony/src/modules/monitoring/kube_prometheus/helm_prometheus_alert_score.rs
+++ b/harmony/src/modules/monitoring/kube_prometheus/helm_prometheus_alert_score.rs
@@ -31,7 +31,7 @@ impl<T: Topology + HelmCommand + TenantManager> Score<T> for HelmPrometheusAlert
             sender: KubePrometheus { config },
             receivers: self.receivers.clone(),
             rules: self.rules.clone(),
-            scrape_target: vec![],
+            scrape_targets: None,
         })
     }
     fn name(&self) -> String {