From c270548e6ebf98ec0f80d7cab39eb542439173d6 Mon Sep 17 00:00:00 2001
From: Taha Hawa <taha@taha.dev>
Date: Wed, 23 Apr 2025 14:21:19 -0400
Subject: [PATCH] Add TODO for getting NS from kube, making it optional

---
 harmony/src/modules/helm/chart.rs | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/harmony/src/modules/helm/chart.rs b/harmony/src/modules/helm/chart.rs
index 737e15e..c4dad5e 100644
--- a/harmony/src/modules/helm/chart.rs
+++ b/harmony/src/modules/helm/chart.rs
@@ -14,7 +14,7 @@ use std::path::PathBuf;
 
 #[derive(Debug, Clone, Serialize)]
 pub struct HelmChartScore {
-    pub namespace: NonBlankString,
+    pub namespace: Option<NonBlankString>,
     pub release_name: NonBlankString,
     pub chart_name: NonBlankString,
     pub chart_version: NonBlankString,
@@ -43,9 +43,14 @@ impl<T: Topology + HelmCommand> Interpret<T> for HelmChartInterpret {
         _inventory: &Inventory,
         _topology: &T,
     ) -> Result<Outcome, InterpretError> {
+        let ns = self
+            .score
+            .namespace
+            .as_ref()
+            .unwrap_or(todo!("Get namespace from active kubernetes cluster"));
         let helm_executor = DefaultHelmExecutor::new();
         let res = helm_executor.install_or_upgrade(
-            &self.score.namespace,
+            ns,
             &self.score.release_name,
             &self.score.chart_name,
             Some(&self.score.chart_version),